Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: NativeFunctionTypeDeclarationCasingFixer - do not require T_STRING present in code #6812

Merged
merged 2 commits into from Mar 11, 2023
Merged

bug: NativeFunctionTypeDeclarationCasingFixer - do not require T_STRING present in code #6812

merged 2 commits into from Mar 11, 2023

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@kubawerlos kubawerlos marked this pull request as ready for review March 9, 2023 20:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4378332883

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.91%

Totals Coverage Status
Change from base Build 4357889410: 0.0%
Covered Lines: 22735
Relevant Lines: 24470

💛 - Coveralls

Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes cover scenario for arrow function that IMHO should be fixed too, but it isn't:

Code build on input code must match expected code.
Failed asserting that two strings are identical.
Expected :'<?php return fn (callable $c): int => 1;'
Actual   :'<?php return fn (CALLABLE $c): INT => 1;'

@kubawerlos kubawerlos enabled auto-merge (squash) March 10, 2023 15:07
@kubawerlos kubawerlos added the RTM Ready To Merge label Mar 11, 2023
@keradus keradus disabled auto-merge March 11, 2023 23:45
@keradus keradus merged commit 6e461ae into PHP-CS-Fixer:master Mar 11, 2023
@keradus keradus removed the RTM Ready To Merge label Mar 11, 2023
@kubawerlos kubawerlos deleted the fix_NativeFunctionTypeDeclarationCasingFixer branch March 12, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants