Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: update PHPStan to 1.10.3 #6805

Merged
merged 2 commits into from Mar 7, 2023
Merged

DX: update PHPStan to 1.10.3 #6805

merged 2 commits into from Mar 7, 2023

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@kubawerlos kubawerlos changed the title Update PHPStan to 1.10.3 DX: update PHPStan to 1.10.3 Mar 3, 2023
@coveralls
Copy link

coveralls commented Mar 3, 2023

Pull Request Test Coverage Report for Build 4330209870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.906%

Totals Coverage Status
Change from base Build 4307743648: 0.0%
Covered Lines: 22735
Relevant Lines: 24471

💛 - Coveralls

@@ -10,6 +10,7 @@ parameters:
- tests
excludePaths:
- tests/Fixtures
treatPhpDocTypesAsCertain: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually wondering about this and I'm not convinced.
was this option introduced only at 1.10? what was the default behaviour on 1.9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is much older than 1.9.

I wasn't convinced to use it after reading the description in config, but this comment explains that we can have it:

treatPhpDocTypesAsCertain is for cases when you have precise phpDoc but you also have to check for other types because the type is only in phpDoc and the caller (which can be outside of the analyzed scope) doesn't adhere to the phpDoc. So you have no other option than make the analyser a little bit "dumber".

phpstan.neon Show resolved Hide resolved
@kubawerlos kubawerlos merged commit e8ea381 into PHP-CS-Fixer:master Mar 7, 2023
@kubawerlos kubawerlos deleted the update_phpstan branch March 7, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants