Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: PHP8.2 - handle union and intersection types for DNF types #6804

Merged
merged 8 commits into from Mar 11, 2023
Merged

minor: PHP8.2 - handle union and intersection types for DNF types #6804

merged 8 commits into from Mar 11, 2023

Conversation

kubawerlos
Copy link
Contributor

@coveralls
Copy link

coveralls commented Mar 2, 2023 •
edited

Pull Request Test Coverage Report for Build 4376522851

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 92.903%
Totals Coverage Status
Change from base Build 4307743648: -0.003%
Covered Lines: 22711
Relevant Lines: 24446
💛 - Coveralls

@kubawerlos kubawerlos added the topic/PHP8.2 Related to features available in PHP 8.2+ label Mar 7, 2023
@kubawerlos kubawerlos changed the title minor: PHP8.2 - support DNF types minor: PHP8.2 - handle union and intersection types for DNF types Mar 7, 2023
@kubawerlos kubawerlos enabled auto-merge (squash) March 10, 2023 15:05
@kubawerlos kubawerlos added the RTM Ready To Merge label Mar 11, 2023
keradus
keradus reviewed Mar 11, 2023
View reviewed changes
src/Tokenizer/AbstractTypeTransformer.php
@@ -21,76 +21,47 @@
*/
abstract class AbstractTypeTransformer extends AbstractTransformer
{
private const TYPE_END_TOKENS = [')', [T_CALLABLE], [T_NS_SEPARATOR], [T_STRING], [CT::T_ARRAY_TYPEHINT]];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope our tests are well enough to ensure we don't break anything accidentally with change in this file

@keradus
Copy link
Member

keradus commented Mar 11, 2023

thanks @kubawerlos !
also @SpacePossum for initial PR

@kubawerlos kubawerlos merged commit e561bd1 into PHP-CS-Fixer:master Mar 11, 2023
@kubawerlos kubawerlos deleted the php82_dnf branch March 11, 2023 23:50
@keradus keradus removed the RTM Ready To Merge label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
topic/PHP8.2 Related to features available in PHP 8.2+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @coveralls @keradus @Wirone