DX: Add composer keywords #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4277031245
💛 - Coveralls |
keradus
reviewed
Feb 15, 2023
composer.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "name": "friendsofphp/php-cs-fixer", | |||
| "description": "A tool to automatically fix PHP code style", | |||
| "license": "MIT", | |||
| "keywords": ["dev", "code style", "code-style", "fixer"], | |||
There was a problem hiding this comment.
cs, sca, ...
also, are code style and code-style really treated differently?
There was a problem hiding this comment.
we coud add a lot of stuff here. the only important one is dev, to make composer work like described above.
we could add anything here. I am open to your suggestions :)
also, are
code styleandcode-stylereally treated differently?
I don't know
There was a problem hiding this comment.
I'd go with fixer, standards and static analysis only, the dev is not really valuable keyword.
There was a problem hiding this comment.
Composer expects one of the following to trigger the desired behavior
dev, testing, static analysis
There was a problem hiding this comment.
adjusted per feedback
kubawerlos
approved these changes
Feb 18, 2023
keradus
reviewed
Feb 26, 2023
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per composer/composer#10960 this allows composer to warn the user, when installing the tool as a project dependency instead of a dev-dependency