feat: phpDoc to property/return/param Fixer - allow fixing union types on PHP >= 8 #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalFlesh
force-pushed
the
feature/fix-union-types-in-phpdocs
branch
2 times, most recently
from
99a104d
to
9c1854d
Compare
keradus
reviewed
Aug 17, 2022
keradus
reviewed
Aug 17, 2022
MortalFlesh
force-pushed
the
feature/fix-union-types-in-phpdocs
branch
from
9c1854d
to
c2f5d68
Compare
MortalFlesh
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
@MortalFlesh is it possible to rebase this PR, so we can check current pipeline result and continue the review process? |
github-actions
bot
added
status/to verify
Wirone
added
status/rebase required
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
status/to verify
Wirone
removed
the
status/to verify
Wirone
force-pushed
the
feature/fix-union-types-in-phpdocs
branch
from
c2f5d68
to
b430241
Compare
Wirone
changed the title
Wirone
force-pushed
the
feature/fix-union-types-in-phpdocs
branch
from
b430241
to
9c96b1f
Compare
Wirone
removed
the
status/rebase required
mvorisek
reviewed
Oct 31, 2023
mvorisek
reviewed
Oct 31, 2023
mvorisek
reviewed
Oct 31, 2023
mvorisek
reviewed
Oct 31, 2023
mvorisek
reviewed
Oct 31, 2023
Wirone
force-pushed
the
feature/fix-union-types-in-phpdocs
branch
4 times, most recently
from
5162b5c
to
dcdc5c2
Compare
kubawerlos
approved these changes
Nov 2, 2023
Wirone
force-pushed
the
feature/fix-union-types-in-phpdocs
branch
from
bb6d318
to
d3d1675
Compare
Wirone
force-pushed
the
feature/fix-union-types-in-phpdocs
branch
from
d3d1675
to
5b522f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
while I was doing
mixedtype PR (#6356) I noticed, thatunion-typesare not handled by the phpdocs fixers. So I decided to make it possible.It was quite harder, than I originally though (as usually.. 🤔 ) but in the end, it works good - at least I hope so :)
There are still a few points, which makes this a more like the draft more than a PR, since I needed to skip some assertions in theMaintainer's note: there was problem with comparingAssertTokensTrait. I would fix it too, but for now, I don't understand the tokens test and I didn't have time to dig in it. I might have some time next week, but I'd appreciate some help with that.Tokensbefore/after applying fix, it was fixed.Also I updated theMaintainer's note: it was removed during rebase, because the fix was already inTypeExpressionclass to handlenullabletyped by?prefix. It is a separate commit and I could send it as a separate PR if needed. Yet I'm not sure if it is needed, since it does not have an impact for anything else. (At least according to tests.)master.And this PR contains the commit from aMaintainer's note: already merged, and this one is rebased on top of that.mixedPR, so it needs to be rebased later to contain just theunion-types.