Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Regression on some detection case showcased in the documentation (#371) #378

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Ousret
Copy link
Collaborator

@Ousret Ousret commented Oct 31, 2023

This PR also added a noise (md) probe that identify malformed arabic representation due to the presence of letters in isolated form (credit to my wife, thanks!)

Close #371

)

and added noise (md) probe that identify malformed arabic representation due to the presence of letters in isolated form (credit to my wife, thanks!)
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a4b9b01) 89.98% compared to head (5226e8f) 90.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   89.98%   90.06%   +0.08%     
==========================================
  Files          12       12              
  Lines        1208     1238      +30     
==========================================
+ Hits         1087     1115      +28     
- Misses        121      123       +2     
Files Coverage Δ
charset_normalizer/md.py 95.34% <100.00%> (+0.26%) ⬆️
charset_normalizer/utils.py 84.86% <85.71%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ousret Ousret merged commit 79dce48 into master Oct 31, 2023
30 checks passed
@Ousret Ousret deleted the fix-detect-regression branch October 31, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect encoding detected in 3.3.1
2 participants