Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix unreachable code in the sorting algorithm of CharsetMatch #352

Merged
merged 1 commit into from Sep 30, 2023

Conversation

Ousret
Copy link
Owner

@Ousret Ousret commented Sep 30, 2023

Close #350

@Ousret Ousret added the bug Something isn't working label Sep 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (58f69f7) 89.80% compared to head (683237c) 89.96%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   89.80%   89.96%   +0.16%     
==========================================
  Files          12       12              
  Lines        1206     1206              
==========================================
+ Hits         1083     1085       +2     
+ Misses        123      121       -2     
Files Coverage Δ
charset_normalizer/models.py 90.80% <100.00%> (+1.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ousret Ousret merged commit 5aed9a4 into master Sep 30, 2023
32 checks passed
@Ousret Ousret deleted the fix-sort-charsetmatch branch September 30, 2023 05:48
chris-ha458 added a commit to chris-ha458/charset-normalizer-rs_original that referenced this pull request Sep 30, 2023
@nickspring
Copy link

@Ousret could you please check accuracy in Python library after this change? In Rust version accuracy was decreased for 1.2%.

@Ousret
Copy link
Owner Author

Ousret commented Oct 2, 2023

See https://github.com/Ousret/charset_normalizer/actions/runs/6360788520/job/17274827059
It did not.
Could be because Rust doesn't have the same list of charsets available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IS this code reachable?
3 participants