Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate logic in Votes.sol #5314

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Nov 21, 2024

Fixes #N-02

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
wyattjoh Wyatt Johnson
@Amxx Amxx added this to the 5.2-after-freeze milestone Nov 21, 2024
@Amxx Amxx requested a review from a team November 21, 2024 15:59
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: eb51fbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
wyattjoh Wyatt Johnson
@Amxx Amxx requested a review from ernestognw November 22, 2024 15:59
@ernestognw ernestognw changed the title Votes: deduplicate logic Deduplicate logic in Votes.sol Nov 25, 2024
@ernestognw ernestognw merged commit c3cb7a0 into OpenZeppelin:master Nov 25, 2024
17 checks passed
@Amxx Amxx deleted the audit/n-02 branch November 26, 2024 14:39
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Nov 30, 2024
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Nov 30, 2024
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants