Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Defender Admin with Transaction Proposals #4804

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Replace Defender Admin with Transaction Proposals #4804

merged 3 commits into from
Dec 22, 2023

Conversation

cairoeth
Copy link
Contributor

Replaces old Defender Admin references and updates Defender description.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2023 •
edited

⚠️ No Changeset found

Latest commit: 0628483

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw changed the title 📝 Replace Defender Admin with Transaction Proposals Replace Defender Admin with Transaction Proposals Dec 20, 2023
@ernestognw
Copy link
Member

Although I like the emojis, we agreed on a guideline for PRs. Updated the title.

ernestognw
ernestognw reviewed Dec 20, 2023
View reviewed changes
docs/modules/ROOT/pages/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance.adoc Outdated Show resolved Hide resolved
@ernestognw ernestognw requested a review from Amxx December 20, 2023 18:59
cairoeth and others added 2 commits December 22, 2023 16:20
@cairoeth @ernestognw
🔗 Defender Transaction Proposals point to docs
74ebcb5 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
@cairoeth @ernestognw
🔗 Defender Transaction Proposals point to docs
0628483 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
ernestognw
ernestognw approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestognw ernestognw merged commit abcf9dd into OpenZeppelin:master Dec 22, 2023
18 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 22, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

GitPOAP: 2023 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

ernestognw added a commit that referenced this pull request Dec 22, 2023
@cairoeth @ernestognw
Replace Defender Admin with Transaction Proposals (#4804)
f7bb988 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
@ernestognw
Copy link
Member

Ha! You probably got the last 2023 gitpoap @cairoeth

This made me think we should replace it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Awaiting requested review from Amxx

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cairoeth @ernestognw