Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Find lua via CMake instead of hardcoding Lua51 #25

Merged
merged 1 commit into from
Mar 8, 2025
Merged

cmake: Find lua via CMake instead of hardcoding Lua51 #25

merged 1 commit into from
Mar 8, 2025
+2 −1

Conversation

AMS21
Copy link

@AMS21 AMS21 commented Mar 7, 2025

No description provided.

@AMS21
cmake: Find lua via CMake instead of hardcoding Lua51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
f9b88f6
@Xottab-DUTY
Copy link
Member

I wonder if we will have to patch Lua 5.1 also.
For example, GSC was using patched LuaJIT with support for C-style comments in Shadow of Chernobyl and we had to add support for them in our LuaJIT – OpenXRay/LuaJIT@b5ef6ba.
Maybe there's a fast enough way to preprocess such scripts before passing them to Lua.

@Xottab-DUTY Xottab-DUTY merged commit 41999f0 into OpenXRay:xray Mar 8, 2025
@AMS21 AMS21 deleted the cmake_find_lua branch March 8, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AMS21 @Xottab-DUTY