Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many unneeded dependencies pulled in from odftoolkit #4397

Closed
wetneb opened this issue Dec 30, 2021 · 0 comments · Fixed by #4398
Closed

Many unneeded dependencies pulled in from odftoolkit #4397

wetneb opened this issue Dec 30, 2021 · 0 comments · Fixed by #4398
Labels
PR: Dependencies Used for pull requests that update the project's dependencies to newer versions. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Dec 30, 2021

We currently pull in a lot of unneeded dependencies from the odftoolkit Java library. Thankfully this has happened after 3.5.1, so we have not released anything with those dependencies yet.

See tdf/odftoolkit#142

Additionally, version 0.10.0 of this toolkit depends on org.json, which was not the case in 0.9.0. Therefore we need to roll back to 0.9.0.
tdf/odftoolkit#144
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. PR: Dependencies Used for pull requests that update the project's dependencies to newer versions. labels Dec 30, 2021
wetneb added a commit to wetneb/OpenRefine that referenced this issue Dec 30, 2021
@wetneb
Change odftoolkit version to 0.9.0. Closes OpenRefine#4397.
88c9dd3
@wetneb wetneb mentioned this issue Dec 30, 2021
Merged
wetneb added a commit that referenced this issue Dec 30, 2021
@wetneb
Change odftoolkit version to 0.9.0. Closes #4397. (#4398)
57b0ce9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR: Dependencies Used for pull requests that update the project's dependencies to newer versions. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change odftoolkit version to 0.9.0. wetneb/OpenRefine
1 participant
@wetneb