Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values in liberty-plugin-config.xml for assemblyArtifact and assemblyInstallDirectory #1795

Closed
cherylking opened this issue Feb 15, 2024 · 1 comment · Fixed by #1796

Comments

@cherylking
Copy link
Member

When using an external Liberty installation (indicated by the installDirectory config parameter in pom.xml), there should be no assemblyArtifact or assemblyInstallDirectory in the liberty-plugin-config.xml since our plugin did not download/install the artifact. Plus, I see no benefit in the assemblyInstallDirectory value, as it is the same as the installDirectory value in the case that it is a local installation in the target folder.

So I think assemblyInstallDirectory should be omitted completely for all scenarios, and assemblyArtifact should be omitted when installDirectory is configured.

Note that LGP already does not include assemblyInstallDirectory in the xml file.

@cherylking
Copy link
Member Author

This is what is currently included in the xml file when an installDirectory is specified.

<assemblyArtifact>
        <type>jar</type>
    </assemblyArtifact>
    <assemblyInstallDirectory>/Users/cherylking/gitForks/guide-getting-started/finish/target/liberty</assemblyInstallDirectory>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant