Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure create server updates plugin config xml after copying config files #1792

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

cherylking
Copy link
Member

Fixes #1788

@cherylking
Copy link
Member Author

cherylking commented Feb 15, 2024

I changed exportParametersToXml to take a boolean to indicate whether the server specific config should be included (the values of which are only valid after copyConfigFiles() is called). To test it, I added a log statement indicating whether the method was called with true or false. When true is passed, the server specific config is included. Here is a screenshot showing the first call has the value false (this is from PluginConfigSupport.installServerAssembly()), and the second and third calls have the value true (this is from PluginConfigSupport.copyConfigFiles() which is called from the create goal and the deploy goal in the test case I ran).

Screenshot 2024-02-15 at 4 32 02 PM

Copy link
Member

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might have some small difference in the <refresh> element value after this PR, but I think the new behavior is consistent enough. It's hard to imagine a tool getting too much value out of this value in any case, so not worried about the change.

@cherylking cherylking merged commit 0db0a28 into OpenLiberty:main Feb 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants