Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire MethodReader fails to clear List before populating #894

Closed
alamar opened this issue May 16, 2024 · 4 comments
Closed

Wire MethodReader fails to clear List before populating #894

alamar opened this issue May 16, 2024 · 4 comments
Assignees
@tgd

Comments

@alamar
Copy link
Contributor

alamar commented May 16, 2024

Please see the PR - if there is a fix please backport to x.24
alamar added a commit that referenced this issue May 16, 2024
@alamar
Add a test for reading an object with list field #894
Loading
Loading status checks…
09834a8
@alamar alamar mentioned this issue May 16, 2024
Closed
@alamar
Copy link
Contributor Author

alamar commented May 24, 2024 

    // Definition of a DTO with a list-containing field.
    public static class ListContainingDto {
        Object list;
    }

(see the PR)
Changing type to List will work around the issue. Adding extends AbstractMarshallableCfg will also would.

@tgd tgd self-assigned this Jun 4, 2024
@tgd
Copy link
Contributor

tgd commented Jun 4, 2024

Thank you for the detailed reproducer Ilya. This is now scheduled, I will send an update soon.

peter-lawrey added a commit that referenced this issue Jun 5, 2024
@peter-lawrey
Handle recycling of values in lists that are not in a List field, Fixes
Loading
Loading status checks…
f4779d0 
#894
@peter-lawrey peter-lawrey mentioned this issue Jun 5, 2024
Merged
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Wire-2.26ea1, BOM-2.26ea10

alamar pushed a commit that referenced this issue Jul 15, 2024
@peter-lawrey @alamar
Handle recycling of values in lists that are not in a List field, Fix… (
Loading
Loading status checks…
e2b7f7a 
#900)

* Handle recycling of values in lists that are not in a List field, Fixes #894

* fix two raw types
@alamar alamar mentioned this issue Jul 15, 2024
Merged
alamar pushed a commit that referenced this issue Jul 15, 2024
@peter-lawrey @alamar
Handle recycling of values in lists that are not in a List field, Fix… (
Loading
Loading status checks…
a9faee4 
#900)

* Handle recycling of values in lists that are not in a List field, Fixes #894

* fix two raw types
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Wire-2.25.21, BOM-2.25.75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgd tgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tgd @alamar @hft-team-city