Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: If running a command that never returns, it gets stuck #1895

Closed
2 tasks done
tholum opened this issue May 18, 2024 · 3 comments · Fixed by #2034
Closed
2 tasks done

[Bug]: If running a command that never returns, it gets stuck #1895

tholum opened this issue May 18, 2024 · 3 comments · Fixed by #2034
Labels
bug Something isn't working severity:low Minor issues, code cleanup, etc

Comments

@tholum
Copy link

tholum commented May 18, 2024

Is there an existing issue for the same bug?

Describe the bug

If durring running a taak it ends up running something that never returns ( like npm run storybook, it freezes and never returns

Current Version

ghcr.io/opendevin/opendevin:0.5

Installation and Configuration

export WORKSPACE_BASE=$(pwd)/workspace
LLM_API_KEY=<REDACTED>

docker run \
    -it \
    --pull=always \
    -e LLM_API_KEY \
    -e SANDBOX_USER_ID=$(id -u) \
    -e WORKSPACE_MOUNT_PATH=$WORKSPACE_BASE \
    -e LLM_MODEL=gpt-4o-2024-05-13 \
    -v $WORKSPACE_BASE:/opt/workspace_base \
    -v /var/run/docker.sock:/var/run/docker.sock \
    -p 8002:3000 \
    --add-host host.docker.internal:host-gateway \
    ghcr.io/opendevin/opendevin:0.5

Running on ubuntu 22:04

Model and Agent

Model : GPT-4o
Agent: CodeActAgent

Reproduction Steps

  1. Give it a task to write a React component and test it with storybook

The prompt I gave it
In the project emsp-frontend

Split DevicePreview.tsx create a CoreDevicePreview that passes a QueueTicket into it, and then change DevicePreview to use CoreDevicePreview

Once that split is done, create a story in storybook for CoreDevicePreview

on a project that had storybook's installed

Logs, Errors, Screenshots, and Additional Context

image It has been stuck on this task for 4 hours
@tholum tholum added the bug Something isn't working label May 18, 2024
@SmartManoj
Copy link
Collaborator

Could you provide the log?

@tholum
Copy link
Author

tholum commented May 19, 2024

I will work on getting the log, I did write a prompt that I am 90% sure will reproduce it ( I am verifying now and it is looking like it hangs the same )

https://github.com/tholum/OpenDevinBugs/blob/main/01_hangs_on_storybook/PROMPT.md

assertion added a commit to assertion/OpenDevin that referenced this issue May 24, 2024
@assertion
fix: codeact bug OpenDevin#1895
00d5b02
@assertion assertion mentioned this issue May 24, 2024
Merged
@SmartManoj
Copy link
Collaborator

timeout works on that command too.

#2034 (comment)

@SmartManoj SmartManoj added the severity:low Minor issues, code cleanup, etc label May 31, 2024
@SmartManoj SmartManoj mentioned this issue Jun 1, 2024
Merged
yufansong added a commit that referenced this issue Jun 8, 2024
@assertion @enyst
@neubig @yufansong
fix: codeact bug [If running a command that never returns, it gets st…
b5a17ef 
…uck #1895] (#2034)

* fix: codeact bug #1895

* fix: add CmdRunAction timeout hint.

* Update agenthub/codeact_agent/prompt.py

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>

* regenerate integration test

---------

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: yufansong <yufan@risingwave-labs.com>
xingyaoww pushed a commit to temotskipa/OpenDevin that referenced this issue Jun 9, 2024
@assertion @enyst
@neubig @yufansong @xingyaoww
fix: codeact bug [If running a command that never returns, it gets st…
629a034 
…uck OpenDevin#1895] (OpenDevin#2034)

* fix: codeact bug OpenDevin#1895

* fix: add CmdRunAction timeout hint.

* Update agenthub/codeact_agent/prompt.py

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>

* regenerate integration test

---------

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: yufansong <yufan@risingwave-labs.com>
li-boxuan added a commit that referenced this issue Jun 9, 2024
@temotskipa @xingyaoww
@frankxu2004 @yufansong @yueqis @enyst @li-boxuan @1jsingh @tobitege @amanape @assertion @neubig
Refactored prompt.py to reduce token usage (#1996)
e925cef 
* Refactored prompt.py to reduce token usage

* Reverted some destructive changes

* Update agenthub/codeact_agent/prompt.py

* Update agenthub/codeact_agent/prompt.py

* Update agenthub/codeact_agent/prompt.py

* Update agenthub/codeact_agent/prompt.py

* Update agenthub/codeact_agent/prompt.py

* Update agenthub/codeact_agent/prompt.py

* Update agenthub/codeact_agent/prompt.py

* Apply suggestions from code review

* Apply suggestions from code review

* Update agenthub/codeact_agent/prompt.py

* fix integration test

* make lint

* feat: support ToolQA benchmark (#2263)

* Add files via upload

* Update README.md

* Update run_infer.py

* Update utils.py

* make lint

* Update evaluation/toolqa/run_infer.py

---------

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Co-authored-by: yufansong <yufan@risingwave-labs.com>
Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>

* feat: revert hiden special paths change in file action (#2328)

* revert change in file action

* remove useless code

* make lint

* Support gpqa benchmark evaluation (#2080)

* feat: add gpqa benchmark evaluation

* add metrics

* reset configs in final block

* make lint

---------

Co-authored-by: yufansong <yufan@risingwave-labs.com>

* fix(frontend): prevent API key from resetting after modal change (#2329)

* remove bottom chatbox fade

* Modal wider; fix lint error

* settings: attempt to not clear api key for same provider

* prevent api key from resetting after changing the model

* revert other changes and fix post test tear down error

---------

Co-authored-by: amanape <83104063+amanape@users.noreply.github.com>

* fix: codeact bug [If running a command that never returns, it gets stuck #1895] (#2034)

* fix: codeact bug #1895

* fix: add CmdRunAction timeout hint.

* Update agenthub/codeact_agent/prompt.py

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>

* regenerate integration test

---------

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: yufansong <yufan@risingwave-labs.com>

* Feat: Support Gorilla APIBench  (#2081)

* removed unused files from gorilla

* Update run_infer.py, removed unused imports

* Update utils.py

* Update ast_eval_hf.py

* Update ast_eval_tf.py

* Update ast_eval_th.py

* Create README.md

* Update run_infer.py

* make lint

* Update run_infer.py

* fix lint

---------

Co-authored-by: yufansong <yufan@risingwave-labs.com>

* remote useless (#2332)

* fix integration test

* Update agenthub/codeact_agent/prompt.py

* Update agenthub/codeact_agent/prompt.py

* fix integration test

---------

Co-authored-by: Xingyao Wang <xingyao6@illinois.edu>
Co-authored-by: Frank Xu <frankxu2004@gmail.com>
Co-authored-by: yufansong <yufan@risingwave-labs.com>
Co-authored-by: yueqis <141804823+yueqis@users.noreply.github.com>
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>
Co-authored-by: Yufan Song <33971064+yufansong@users.noreply.github.com>
Co-authored-by: Jaskirat Singh <1.jaskiratsingh@gmail.com>
Co-authored-by: tobitege <tobitege@gmx.de>
Co-authored-by: amanape <83104063+amanape@users.noreply.github.com>
Co-authored-by: Aaron Xia <zhhuaxia@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working severity:low Minor issues, code cleanup, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: codeact bug [If running a command that never returns, it gets stuck #1895] assertion/OpenDevin
2 participants
@tholum @SmartManoj