[minor] office-addin-lint: update package versions #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerds
reviewed
Apr 4, 2024
| @@ -11,7 +11,7 @@ const eslintPath = require.resolve("eslint"); | |||
| const prettierPath = require.resolve("prettier"); | |||
| const eslintDir = path.parse(eslintPath).dir; | |||
| const eslintFilePath = path.resolve(eslintDir, "../bin/eslint.js"); | |||
| const prettierFilePath = path.resolve(prettierPath, "../bin-prettier.js"); | |||
| const prettierFilePath = path.resolve(prettierPath, "../bin/prettier.cjs"); | |||
There was a problem hiding this comment.
I'm not very familiar with the prettier setup . . . what is effect of this (this is not a file in this package itself)?
There was a problem hiding this comment.
It's in the prettier code. I suppose you could ask whether the command should use npx instead, but the change here is just to match changes within prettier itself for its code.
There was a problem hiding this comment.
Makes sense . . . I just haven't seen that file used anywhere so I wasn't sure how it was used.
millerds
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the package versions for office-addin-lint.
For context, I was working on a project derived from Office-Addin-TaskPane-React template which involves custom functions, and was running into strange errors from eslint in TypeScript code in VS Code. I noticed that eslint was very out of date. After updating these package versions, building Office-Addin-Scripts and linking to office-addin-lint from the project, it fixed the errors.
NOTE: I removed engines-strict in .npmrc so I could use Node LTS.
I always wanted to mention that I think there should be a process to regularly update packages to newer versions across the repository. Relying only on dependabot or making updates only for addressing vulnerabilities isn't really enough. It's better to stay current with TypeScript, eslint, react, etc.
Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)
No
Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)
No
Validation/testing performed:
I validated this in the project I was working on. Running the Dev Server in VS Code did not show any errors.
I didn't get any lint errors in the project after linking to the new version of office-addin-lint.
npm run buildin the project had no errors.I ran
npm installandnpm run buildin the root of the repository and there were no errors.I ran
npm run testin office-addin-lint project.I noticed that
npm run prettierin the template project wasn't working, so I fixed the path and it works now.