Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"dotnet list package --deprecated" should report unlisted packages #12643

Open
cremor opened this issue Jun 8, 2023 · 3 comments
Open

"dotnet list package --deprecated" should report unlisted packages #12643

cremor opened this issue Jun 8, 2023 · 3 comments
Labels
Functionality:ListPackage dotnet.exe list package Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Type:DCR Design Change Request

Comments

@cremor
Copy link

cremor commented Jun 8, 2023

NuGet Product(s) Affected

dotnet.exe

Current Behavior

dotnet list package --deprecated only finds deprecated packages.

Desired Behavior

dotnet list package --deprecated should find deprecated and unlisted packages.

Additional Context

Your guide Best practices for a secure software supply chain says the following:

To protect the .NET package ecosystem when you are aware of a vulnerability in a package you have authored, do your best to deprecate and unlist the package [...]

But this guideline is not even followed by your own team as can be seen in the case #11883 (comment)

Also, as far as I know unlisting a package version has been possible for longer than deprecating has. So there might be many old packages out there which should not be used, but can't be found with the currently available commands.

Package consumers should have a way to figure out if they are using any unlisted packages.

An alternative would be a new dotnet list package --unlisted option. But in my opinion it is already annoying that --vulnerable and --deprecated can't be used at the same time, so I wouldn't want to execute a third command to find all "bad" packages.

@jeffkl
Copy link
Contributor

jeffkl commented Jun 15, 2023

Team Triage: We have concerns that implying that a user who unlisted a package wants us to represent it as deprecated would be bad. Now that users can explicitly deprecate a package, we'd prefer them to convey that themselves. But if the community feels like it's an okay inference that an unlisted package is considered deprecated, we can consider this feature.

@jeffkl jeffkl added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Pipeline:Icebox labels Jun 15, 2023
@cremor
Copy link
Author

cremor commented Jun 16, 2023

@jeffkl Is there an alternative how #11883 (comment) can be handled/noticed?

@WGroenestein
Copy link

Can we please get unlisted package versions included in the --vulnerable flag. The MS guidance in case of a vulnerability is too unlist resulting in that developers are not notified when they rely on "dotnet list package --vulnerable --include-transitive" as suggested in this blog post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:ListPackage dotnet.exe list package Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

4 participants