Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow node 16 #472

Closed
OleksiiKachan opened this issue Aug 2, 2023 · 5 comments · Fixed by #473
Closed

allow node 16 #472

OleksiiKachan opened this issue Aug 2, 2023 · 5 comments · Fixed by #473

Comments

@OleksiiKachan
Copy link

cypress-wait-until/package.json

Line 7 in 0a1545b

"node": ">=18.16.0",

please allow node 16. not everybody can bump to 18 yet. 16 has good half a year at least yet
@knorrium
Copy link
Contributor

knorrium commented Aug 4, 2023

@OleksiiKachan thanks for raising this.

It took me a while to realize this was causing my Github Action to fail due to webpack compilation errors. My action was set to run on Node v16 - after updating it to v18, the tests ran fine again.

@NoriSte I think this should have been called out in the release notes as part of the breaking changes.

@NoriSte
Copy link
Owner

NoriSte commented Aug 4, 2023

Sure, that's my bad! I hope to find the span to fix it quickly.

@knorrium knorrium mentioned this issue Aug 4, 2023
Merged
NoriSte pushed a commit that referenced this issue Aug 5, 2023
@knorrium
chore(deps): Unset the Node.js and NPM version
213b780 
fix #472
@NoriSte
Copy link
Owner

NoriSte commented Aug 5, 2023

@all-contributors please add @OleksiiKachan for bug

@allcontributors allcontributors bot mentioned this issue Aug 5, 2023
Merged
@allcontributors
Copy link
Contributor

@NoriSte

I've put up a pull request to add @OleksiiKachan! 🎉

@NoriSte
Copy link
Owner

NoriSte commented Aug 5, 2023

Let me know if it works, thank you all and sorry ❤️

NoriSte added a commit that referenced this issue Dec 1, 2023
@NoriSte
fix: unset the Node.js version
d6af89d 
Avoid #472 again
@NoriSte NoriSte mentioned this issue Dec 1, 2023
Merged
NoriSte added a commit that referenced this issue Dec 1, 2023
@NoriSte
fix: unset the Node.js version (#479)
236db14 
Avoid #472 again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): Revert: Set the Node and NPM version knorrium/cypress-wait-until
3 participants
@knorrium @NoriSte @OleksiiKachan