-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python package set: normalize all attribute names #49691
Comments
Fixing the attribute names won't cause any rebuilds, but indeed, it will break people's configuration.
We should look at adding a test to Nixpkgs so we can enforce this. |
Since I am quite new I am not aware of how to add a test to Nixpkgs. Are you suggesting a Edit: I see the pkgs tests |
After the 19.03 release I would like to work on this in an automated fashion to see how far it goes. Having normalized names would allow tools such as https://github.com/t184256/nixpkgs-python-importer and https://github.com/nix-community/nixpkgs-pytools to get the package name correct and in general not force users to guess on the name of a python package. @FRidh do you have suggestions on how this should be approached? Right now I am considering an adhoc approach manual/https://github.com/Mic92/pythonix to read the derivation names. |
Yes, use Furthermore, when checking this, it's possible to check whether the attribute name is normalized. |
How would we handle renaming? Obviously this would break for a lot of people who depend on nixpkgs if the transition was done immediately. Would there be a way to depreciate the attribute names? (this is likely due to me not knowing enough of nixpkgs). |
Deprecation is in my opinion just generating work. If we feel this is worth it we should do it and then I think it's best to just get it over with. |
Okay I will work on this in the coming weeks. With a goal of making it as automated as possible. I don't want to manually create 500+ commits again 😄 |
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
See #96586 |
I marked this as stale due to inactivity. → More info |
Replaced by #245383. |
Issue description
The convention in
python-packages.nix
is to use normalized names although far from every attribute fulfills this requirement.Having all packages conform will simplify things for automation.
Note that the scope is only the attribute names, and not the
pname
attributes.cc @costrouc
The text was updated successfully, but these errors were encountered: