Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoraxy: init at 3.0.5 #312849

Merged
merged 1 commit into from
Jun 2, 2024
Merged

zoraxy: init at 3.0.5 #312849

merged 1 commit into from
Jun 2, 2024

Conversation

luftmensch-luftmensch
Copy link
Contributor

Description of changes

Closes #312814

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@luftmensch-luftmensch
Copy link
Contributor Author 

> nix build .#zoraxy
> tree result
 result
└──  bin
   └──  zoraxy

Tested ./result/bin/zoraxy creating a new account

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3965

SuperSandro2000
SuperSandro2000 reviewed May 20, 2024
View reviewed changes
pkgs/by-name/zo/zoraxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/zo/zoraxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/zo/zoraxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/zo/zoraxy/package.nix Outdated Show resolved Hide resolved
@luftmensch-luftmensch
Copy link
Contributor Author

@SuperSandro2000 Applied suggestion.

Note: For the tests I had a few, but should be good to go now

@luftmensch-luftmensch
Copy link
Contributor Author

@SuperSandro2000 bumped version to 3.0.5

Release notes

@luftmensch-luftmensch luftmensch-luftmensch changed the title zoraxy: init at 3.0.4 zoraxy: init at 3.0.5 May 27, 2024
@SuperSandro2000 SuperSandro2000 merged commit 014958c into NixOS:master Jun 2, 2024
26 checks passed
@luftmensch-luftmensch luftmensch-luftmensch deleted the zoraxy_3.0.4 branch June 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Zoraxy
3 participants
@luftmensch-luftmensch @nixos-discourse @SuperSandro2000