fix: support numeric entities with values over 0xFFFF #726
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. can you please remove spaces changes? It shows changes on multiple lines unnecessary. |
Numeric entities over U+FFFF would be truncated to their lower two bytes due to use of `String.fromCharCode` which only returns a UTF-16 single code unit. Replacing the relevant calls with `String.fromCodePoint` addresses the problem.
mcdurdin
force-pushed
the
fix/non-bmp-numeric-entities
branch
from
b009425 to
c8b4956
Compare
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Numeric entities over U+FFFF would be truncated to their lower two bytes due to use of
String.fromCharCodewhich only returns a UTF-16 single code unit. Replacing the relevant calls withString.fromCodePointaddresses the problem. (See caniuse.com for compatibility.)Fixes #725.
Type
Please mention the type of PR
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]in PR title. Your PR will be reviewed when[WIP]will be removed from the PR title.Bookmark this repository for further updates.