fix: include CommonJS resources in the npm package #714
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `package.json` file didn't declare a "files" attribute, so default files were included, but not the files in the lib folder (which includes CommonJS resources)
7 tasks
Vulnerable Libraries (1)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
amitguptagwl
merged commit 5d9f416
into
NaturalIntelligence:master
3 of 4 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
The
package.jsonfile didn't declare a "files" attribute, so default files were included, but not the files in the lib folder (which includes CommonJS resources)Closes #713
I have run npm pack with the new configuration to verify that the content is the same as in https://www.npmjs.com/package/fast-xml-parser/v/5.0.1?activeTab=code and includes the lib folder.
Type
Please mention the type of PR