Remove trailing slash from jPath for self-closing tags #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitguptagwl
merged commit 2f2f787
into
NaturalIntelligence:master
7 of 8 checks passed
|
Hey @amitguptagwl, any chance you could release a new version with this fix? |
|
Done. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Fixes #564
The
jPathinupdateTag()callback for self-closing tags contained a trailing slash (like:root.a/) which was not intended and could lead to errors if you implemented logic based on thejPathand did not take that into account.I've added removing trailing slash from
jPathin the same place where it's removed fromtagName.Type
Please mention the type of PR