Added model config params for Canary-1B-Flash, Canary-180M-Flash models #12588
+25
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinraok
previously approved these changes
Mar 13, 2025
| @@ -7,6 +7,15 @@ | |||
| # One extra (linear projection) layer is added between FastConformer encoder and Transformer decoder if they have different hidden sizes | |||
| # It is recommended to initialize FastConformer with ASR/SSL pre-trained encoder for better accuracy and faster convergence | |||
|
|
|||
| # Canary model family | |||
There was a problem hiding this comment.
Can you add a sample training manifest json line to the top of the file
There was a problem hiding this comment.
Something like this?
{"audio_filepath": "/path/to/audio/file.wav", "duration": 6.192, "text": "Text spoken in the audio.", "source_lang": "en", "target_lang": "en", "taskname": "asr", "pnc": "yes"}
nithinraok
previously approved these changes
Mar 13, 2025
Signed-off-by: Kunal Dhawan <kunaldhawan97@gmail.com>
Signed-off-by: Kunal Dhawan <kunaldhawan97@gmail.com>
Signed-off-by: Kunal Dhawan <kunaldhawan97@gmail.com>
KunalDhawan
force-pushed
the
add_canary_flash_config
branch
from
5f266b9 to
e0f4402
Compare
Signed-off-by: Kunal Dhawan <kunaldhawan97@gmail.com>
KunalDhawan
requested review from
pablo-garay,
ko3n1g,
thomasdhc and
chtruong814
as code owners
nithinraok
approved these changes
Mar 14, 2025
|
@ko3n1g could you please review, all CICD tests passed |
ko3n1g
approved these changes
Mar 14, 2025
ankitapasad
reviewed
Mar 15, 2025
There was a problem hiding this comment.
Hi @KunalDhawan (cc @pzelasko )
Can we remove these? These are not relevant for canary-flash and we end up passing the same path as argument here and later under model.tokenizers
model_dir: ???
tokens: ["translate", "transcribe", "en", "es", "de", "fr"]
force_rebuild: False # Set to True to build new tokenizer each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Adds model config param table to asr/conf/speech_multitask/fast-conformer_aed.yaml to cover Canary-1B-Flash and Canary-180M-Flash models.
Collection: ASR
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information