FileTarget - Fix Windows FileSystem Tunneling when KeepFileOpen=false #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
added
bug
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving #5426
Bug introduced with #5381 + #5382 + #5384
NLog v5.2.6 tried to make FileTarget more stable by not momentarily releasing-file-handle when starting new log-file. By updating file-timestamp on the newly opened file. But when using FileTarget KeepFileOpen=false, then file-handle is opened with exclusive write-access, and caused
File.SetCreationTimeUtcto fail and not set correct file-creation-timestamp. This meant NLog file-archive-logic would fail together with KeepFileOpen=false.