After call AddNLog header is written twice

[RomanSoloweow]

After call AddNLog header is written twice

Steps to reproduce

1. Config FileTargets with header
2. Enable WriteHeaderWhenInitialFileNotEmpty option
3. Call AddNLog

After call AddNLog header is written twice. If you don't call AddNLog, everything works as expected

I don’t know what the reason could be, but it looks like AddNlog causes FileTarget to be reinitialized or creates its own using the same layout

[RomanSoloweow]

@snakefoot can you check it please?

[snakefoot]

Could you include a minimal reproducable example in source-code? (Or even better an unit-test). Maybe also the output from NLog InternalLogger.

[snakefoot]

Tried to reproduce based on you initial details. And failed to reproduce.

Succes with both NLog.config and LogManager.Setup().LoadConfiguration(...)

[RomanSoloweow]

Could you send me the project with reproduction please? I will try to correct it completely with my logic

[snakefoot]

Just adapt one of the example projects for this git-repo. Maybe using a pull request

[RomanSoloweow]

@snakefoot PR with reproduce: #709

[snakefoot]

When calling builder.AddNLog(logger.Factory.Configuration); then it forces AddNLog to re-assign the configuration (thus closing file-target and all filehandles, followed by re-initializing it again)

Try using builder.AddNLog(), which just installs NLog as Logging-Provider without re-assign of configuration.

[RomanSoloweow]

I can't find a description of this anywhere. + It is not clear what other methods can lead to this. I think it's worth updating the documentation

[snakefoot]

I'm guessing that the behavior was seen as implicit, when calling AddNLog with input-parameter LoggingConfiguration that is meant to be New NLog config:

        /// <summary>
        /// Enable NLog as logging provider for Microsoft Extension Logging
        /// </summary>
        /// <param name="builder"></param>
        /// <param name="configuration">New NLog config.</param>
        /// <returns>ILoggingBuilder for chaining</returns>
        public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, LoggingConfiguration configuration)

But all improvements to documentation are always wellcome. Like the goal of preventing users from faling into traps.

[snakefoot]

@RomanSoloweow Created #710 that tries to improve the XML docs for AddNLog. Feedback is wellcome

[snakefoot]

Closing issue, as the reason has been found. And #710 has been committed, which tries to improve XML-docs.