Skip to content

[TASK] Deprecate the IE hack in Rule #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[TASK] Deprecate the IE hack in Rule #993

merged 1 commit into from
Feb 25, 2025

Conversation

oliverklee
Copy link
Contributor

With modern browsers, we don't need IE hacks anymore.

(Also, this code is not used.)

Verified

This commit was signed with the committer’s verified signature.
oliverklee Oliver Klee
With modern browsers, we don't need IE hacks anymore.

(Also, this code is not used.)
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, these were only needed for versions of IE before IE8, which was released 15 years ago. Nowadays, many websites (e.g. YouTube) won't even run on IE8.

@JakeQZ JakeQZ merged commit 64e37b8 into v8.x Feb 25, 2025
22 checks passed
@JakeQZ JakeQZ deleted the task/deprecate-ie-hack branch February 25, 2025 10:45
oliverklee added a commit that referenced this pull request Feb 26, 2025

Verified

This commit was signed with the committer’s verified signature.
oliverklee Oliver Klee
This is a followup to #993.
JakeQZ pushed a commit that referenced this pull request Feb 26, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This is a followup to #993.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants