Skip to content

[CLEANUP] Add separate OutputFormat properties for arrays #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Feb 6, 2025

SpaceBeforeListArgumentSeparators and SpaceAfterListArgumentSeparators are added to allow for different spacing for different separators.

SpaceBeforeListArgumentSeparator and SpaceAfterListArgumentSeparator will specify the default spacing. Setting these as an array is deprecated.

Resolves #866, #876, #878.

`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

Resolves #866, #876, #878.
@JakeQZ JakeQZ added cleanup enhancement deprecation A method, property, or some functionality has been deprecated. to-backport labels Feb 6, 2025
@JakeQZ JakeQZ added this to the 8.8.0 milestone Feb 6, 2025
@JakeQZ JakeQZ self-assigned this Feb 6, 2025
@coveralls
Copy link

Coverage Status

coverage: 45.629% (-0.05%) from 45.68%
when pulling 4250c18 on cleanup/list-separator-space
into 1fad44a on main.

Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! ❤️

@oliverklee oliverklee merged commit 7a12457 into main Feb 6, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/list-separator-space branch February 6, 2025 15:57
@oliverklee
Copy link
Contributor

Thanks a lot! Would you be willing to also take care of the backport?

@oliverklee
Copy link
Contributor

Resolves #866, #876, #878.

Note: For GitHub to auto-close issues and other PRs when a PR is merged, we'll need to have separate "Resolves/Fixes" lines, one for each issue/PR ID. I've close the #876 and #878 manually now.

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Feb 6, 2025

Thanks a lot! Would you be willing to also take care of the backport?

Will do. IIRC, I use git --cherry-pick to merge a specific change to a branch - ?

@oliverklee
Copy link
Contributor

Yes, cherrypicking is the way to go. 🍒

JakeQZ added a commit that referenced this pull request Feb 6, 2025
`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

This is the backport of #880.
JakeQZ added a commit that referenced this pull request Feb 7, 2025
`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

This is the backport of #880.
JakeQZ added a commit that referenced this pull request Feb 7, 2025
`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

This is the backport of #880.
oliverklee pushed a commit that referenced this pull request Feb 7, 2025
`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

This is the backport of #880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup deprecation A method, property, or some functionality has been deprecated. enhancement to-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants