Skip to content

[TASK] Mark Selector::isValid() as @internal #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

[TASK] Mark Selector::isValid() as @internal #1037

merged 1 commit into from
Feb 28, 2025
+3 −0

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee requested a review from JakeQZ February 28, 2025 09:46
@oliverklee oliverklee self-assigned this Feb 28, 2025
@coveralls
Copy link

coveralls commented Feb 28, 2025 •
edited
Loading

Coverage Status

coverage: 55.282%. remained the same
when pulling c615a95 on task/internal/valid-selector
into 19ffd07 on main.

@oliverklee
[TASK] Mark Selector::isValid() as @internal

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
c615a95
@oliverklee oliverklee force-pushed the task/internal/valid-selector branch from 6464ee5 to c615a95 Compare February 28, 2025 19:53
JakeQZ
JakeQZ approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does indeed seem to be used internally, right before constructing a Selector - rather suggesting that the Selector constructor should be making this check itself instead (beyond the scope of this PR).

@JakeQZ JakeQZ merged commit 3315773 into main Feb 28, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/internal/valid-selector branch February 28, 2025 22:23
oliverklee added a commit that referenced this pull request Feb 28, 2025
@oliverklee
[TASK] [TASK] Mark Selector::isValid() as @internal
Loading
Loading status checks…
b922339 
This is the V8.x backport of #1037.
@oliverklee oliverklee mentioned this pull request Feb 28, 2025
Merged
oliverklee added a commit that referenced this pull request Feb 28, 2025
@oliverklee
[TASK] Mark Selector::isValid() as @internal
Loading
Loading status checks…
a372ef6 
This is the V8.x backport of #1037.
@JakeQZ
Copy link
Contributor

JakeQZ commented Feb 28, 2025

... rather suggesting that the Selector constructor should be making this check itself instead (beyond the scope of this PR).

Added #1041 to capture this.

JakeQZ pushed a commit that referenced this pull request Mar 1, 2025
@oliverklee
[TASK] Mark Selector::isValid() as @internal (#1040)
1ee8a74 
This is the V8.x backport of #1037.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ

Assignees

@oliverklee oliverklee

Labels
to-backport
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliverklee @coveralls @JakeQZ