Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mkdirp (to not use old version of minimist with security vulnerabilities) #2524

Closed
gharlan opened this issue Mar 18, 2020 · 3 comments

Comments

@gharlan
Copy link

gharlan commented Mar 18, 2020

modernizr requires mkdirp 0.5.1.
And mkdirp 0.5.1 requires minimist 0.0.8, which has a security vulnerability: https://snyk.io/vuln/SNYK-JS-MINIMIST-559764

@rejas
Copy link
Member

rejas commented Mar 18, 2020

This dependency wont get updated until the next major version, see #2499 on why I reverted that update.
I'll keep this issue open though to have it as a reminder for whenever that next major version will happen.

@rejas rejas added this to the Modernizr v4.0 milestone Mar 18, 2020
@gharlan
Copy link
Author

gharlan commented Mar 18, 2020

isaacs/node-mkdirp#7

maybe you could update mkdirp from 0.5.1 to 0.5.3?

@rejas rejas modified the milestones: Modernizr v4.0, Modernizr v3.10 Mar 19, 2020
@rejas
Copy link
Member

rejas commented Mar 19, 2020

ah, true. ok, will do :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants