Skip to content

Commit f9e5163

Browse files
barneycarrollStephanHoyer
authored andcommittedFeb 12, 2022
vnode.attrs is never null
1 parent e4c6621 commit f9e5163

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎render/hyperscript.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function execSelector(state, vnode) {
3636
var className = hasClass ? attrs.class : attrs.className
3737

3838
vnode.tag = state.tag
39-
vnode.attrs = null
39+
vnode.attrs = {}
4040

4141
if (!isEmpty(state.attrs) && !isEmpty(attrs)) {
4242
var newAttrs = {}

‎render/tests/test-hyperscript.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ o.spec("hyperscript", function() {
271271
var vnode = m("div", {key:"a"})
272272

273273
o(vnode.tag).equals("div")
274-
o(vnode.attrs).equals(null)
274+
o(vnode.attrs).deepEquals({})
275275
o(vnode.key).equals("a")
276276
})
277277
o("handles many attrs", function() {
@@ -343,7 +343,7 @@ o.spec("hyperscript", function() {
343343
var vnode = m("custom-element", {key:"a"})
344344

345345
o(vnode.tag).equals("custom-element")
346-
o(vnode.attrs).equals(null)
346+
o(vnode.attrs).deepEquals({})
347347
o(vnode.key).equals("a")
348348
})
349349
o("handles many attrs", function() {
@@ -551,20 +551,20 @@ o.spec("hyperscript", function() {
551551
o("handles children without attr", function() {
552552
var vnode = m("div", [m("i"), m("s")])
553553

554-
o(vnode.attrs).equals(null)
554+
o(vnode.attrs).deepEquals({})
555555
o(vnode.children[0].tag).equals("i")
556556
o(vnode.children[1].tag).equals("s")
557557
})
558558
o("handles child without attr unwrapped", function() {
559559
var vnode = m("div", m("i"))
560560

561-
o(vnode.attrs).equals(null)
561+
o(vnode.attrs).deepEquals({})
562562
o(vnode.children[0].tag).equals("i")
563563
})
564564
o("handles children without attr unwrapped", function() {
565565
var vnode = m("div", m("i"), m("s"))
566566

567-
o(vnode.attrs).equals(null)
567+
o(vnode.attrs).deepEquals({})
568568
o(vnode.children[0].tag).equals("i")
569569
o(vnode.children[1].tag).equals("s")
570570
})

0 commit comments

Comments
 (0)
Please sign in to comment.