Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper declaration file for the import condition #200

Merged
merged 2 commits into from May 1, 2023
Merged

Add proper declaration file for the import condition #200

merged 2 commits into from May 1, 2023

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Apr 29, 2023 •
edited

andrewbranch
andrewbranch approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, though perhaps it would be better to rig up a tsc --allowJs --declaration --emitDeclarationOnly to generate this to ensure the named exports stay in sync

@andrewbranch andrewbranch requested a review from rbuckton May 1, 2023 16:35
@andrewbranch
Copy link
Member

This will need to be updated if #179 goes in first

@andrewbranch andrewbranch mentioned this pull request May 1, 2023
Merged
andrewbranch
andrewbranch reviewed May 1, 2023
View reviewed changes
modules/index.d.ts Outdated Show resolved Hide resolved
andrewbranch
andrewbranch reviewed May 1, 2023
View reviewed changes
modules/index.d.ts Outdated Show resolved Hide resolved
@andrewbranch andrewbranch merged commit eab3cff into microsoft:main May 1, 2023
6 checks passed
@Andarist Andarist deleted the fix/import-types branch May 2, 2023 06:28
@jakebailey jakebailey mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@rbuckton rbuckton rbuckton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Andarist @andrewbranch @rbuckton