Adding warning that AssemblyResolution works only with netframworks #1669
+109
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
May 17, 2023
Evangelink
reviewed
May 17, 2023
Evangelink
reviewed
May 18, 2023
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
| @@ -127,6 +128,17 @@ public static MSTestAdapterSettings ToSettings(XmlReader reader) | |||
| return settings; | |||
| } | |||
|
|
|||
| public static void ValidateSettings(IMessageLogger logger) | |||
There was a problem hiding this comment.
Does it need to be public? Can it be internal?
There was a problem hiding this comment.
when I do it protected I can't call it from the MSTestSettings class
There was a problem hiding this comment.
I said internal not protected :P
There was a problem hiding this comment.
ValidateSettings func and the class we are using it inside are in different projects can't make it internal
Evangelink
reviewed
May 19, 2023
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
| @@ -127,6 +128,17 @@ public static MSTestAdapterSettings ToSettings(XmlReader reader) | |||
| return settings; | |||
| } | |||
|
|
|||
| public static void ValidateSettings(IMessageLogger logger) | |||
Evangelink
approved these changes
May 19, 2023
Evangelink
deleted the
adding-Warnning-assemplyesolution-work-only-with-netframworks
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1645