Replace MD5 with Blake2 #1550
Merged
Replace MD5 with Blake2 #1550
+35
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the insecure MD5 hash function with the more secure Blake2b in the hash operator.
- Updated unit and integration tests to validate Blake2b hash outputs instead of MD5.
- Adjusted error messages and documentation to reference Blake2b appropriately, with one noted typo in the docs.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| presidio-anonymizer/tests/operators/test_hash.py | Updated hash tests to replace MD5 with Blake2b. |
| presidio-anonymizer/tests/integration/test_anonymize_engine.py | Changed integration tests to validate Blake2b output. |
| docs/anonymizer/index.md | Modified documentation to reference Blake2b (note a typo present). |
| presidio-anonymizer/presidio_anonymizer/operators/hash.py | Replaced MD5 with Blake2b in the hash operator implementation. |
| presidio-anonymizer/README.md | Updated README documentation to include Blake2b details. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Omri Mendels <omri374@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
approved these changes
Mar 17, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Replace insecure hash function MD5 with Blake2
This PR fixes issue #1541
Checklist