Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom expect matchers on Locator/Page/APIResponse instance #27117

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: custom expect matchers on Locator/Page/APIResponse instance #27117

merged 1 commit into from
Sep 15, 2023

Conversation

mxschmitt
Copy link
Member

Fixes #27113

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-cli-codegen.spec.ts:18:5 › codegen should work

7 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsertype-connect.spec.ts:648:5 › launchServer › should upload large file
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

25615 passed, 605 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 0d44405 into microsoft:main Sep 15, 2023
26 of 28 checks passed
github-actions bot added a commit that referenced this pull request Sep 15, 2023
@github-actions
cherry-pick(#27117): fix: custom expect matchers on Locator/Page/APIR…
6345b66 
…esponse instance
mxschmitt pushed a commit that referenced this pull request Sep 15, 2023
@playwrightmachine @github-actions
cherry-pick(#27117): fix: custom expect matchers on Locator/Page/APIR…
6cc43d8 
…esponse instance (#27125)

This PR cherry-picks the following commits:

- 0d44405

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@mxschmitt @Germandrummer92
fix: custom expect matchers on Locator/Page/APIResponse instance (mic…
2391722 
…rosoft#27117)

Fixes microsoft#27113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REGRESSION]: No longer able to extend PlaywrightTest.Matchers type for locators and pages
2 participants
@mxschmitt @dgozman