Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll to r1076 #26400

Merged
merged 1 commit into from
Aug 10, 2023
Merged

feat(chromium): roll to r1076 #26400

merged 1 commit into from
Aug 10, 2023

Conversation

playwrightmachine
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

Test results for "tests 1"

8 flaky
⚠️ [chromium] › library/tracing.spec.ts:395:14 › should produce screencast frames fit
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/proxy.spec.ts:179:3 › should exclude patterns
⚠️ [playwright-test] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events
⚠️ [playwright-test] › ui-mode-trace.spec.ts:126:5 › should show snapshots for sync assertions
⚠️ [webkit] › library/browsercontext-fetch.spec.ts:1039:3 › should abort requests when browser context closes
⚠️ [webkit] › library/inspector/cli-codegen-python.spec.ts:74:5 › should save the codegen output to a file if specified
⚠️ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events

25021 passed, 583 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 2"

2 failed
❌ [firefox] › page\frame-goto.spec.ts:46:3 › should continue after client redirect
❌ [webkit] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

61 flaky
⚠️ [chromium] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [chromium] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed
⚠️ [chromium] › page/page-mouse.spec.ts:193:3 › should trigger hover state with removed window.Node
⚠️ [chromium] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [chromium] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:395:14 › should produce screencast frames crop
⚠️ [chromium] › library\chromium\connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:44:3 › should report requests and responses handled by service worker
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › library/capabilities.spec.ts:256:3 › requestFullscreen
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library/video.spec.ts:334:5 › screencast › should capture navigation
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/video.spec.ts:712:5 › screencast › should capture full viewport on hidpi
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library\browsercontext-locale.spec.ts:118:3 › should be isolated between contexts
⚠️ [firefox] › library\browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox] › library\browsercontext-reuse.spec.ts:131:1 › should not cache resources
⚠️ [firefox] › library\inspector\cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox] › library\proxy.spec.ts:179:3 › should exclude patterns
⚠️ [firefox] › library\video.spec.ts:227:5 › screencast › saveAs should throw when no video frames
⚠️ [firefox] › library\video.spec.ts:533:5 › screencast › should capture static page in persistent context @smoke
⚠️ [firefox] › page\page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox] › library/headful.spec.ts:83:3 › should dispatch click events to oversized viewports
⚠️ [firefox] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [firefox] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium] › library/capabilities.spec.ts:139:3 › should not crash on showDirectoryPicker
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:482:7 › cli codegen › should check a radio button
⚠️ [webkit] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [webkit] › page/page-network-idle.spec.ts:83:3 › should wait for networkidle to succeed navigation
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:584:7 › cli codegen › should select with size attribute
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [webkit] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:227:7 › cli codegen › should fill
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:501:7 › cli codegen › should check with keyboard
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:520:7 › cli codegen › should uncheck
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:625:7 › cli codegen › should await popup
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:360:7 › cli codegen › should generate getByTestId
⚠️ [webkit] › library\tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [webkit] › page\page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › library/resource-timing.spec.ts:20:3 › should work @smoke
⚠️ [webkit] › page/page-evaluate.spec.ts:507:3 › should transfer 100Mb of data from page to node.js
⚠️ [webkit] › library/browsercontext-fetch.spec.ts:1039:3 › should abort requests when browser context closes
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

100522 passed, 5717 skipped
✔️✔️✔️

[firefox] › page\frame-goto.spec.ts:46:3 › should continue after client redirect

Error: expect(received).toContain(expected) // indexOf

Matcher error: received value must not be null nor undefined

Received has value: undefined

  50 |   const url = server.PREFIX + '/frames/child-redirect.html';
  51 |   const error = await page.goto(url, { timeout: 5000, waitUntil: 'networkidle' }).catch(e => e);
> 52 |   expect(error.message).toContain('page.goto: Timeout 5000ms exceeded.');
     |                         ^
  53 |   expect(error.message).toContain(`navigating to "${url}", waiting until "networkidle"`);
  54 | });
  55 |

    at D:\a\playwright\playwright\tests\page\frame-goto.spec.ts:52:25

Retry 1:

Error: expect(received).toContain(expected) // indexOf

Matcher error: received value must not be null nor undefined

Received has value: undefined

  50 |   const url = server.PREFIX + '/frames/child-redirect.html';
  51 |   const error = await page.goto(url, { timeout: 5000, waitUntil: 'networkidle' }).catch(e => e);
> 52 |   expect(error.message).toContain('page.goto: Timeout 5000ms exceeded.');
     |                         ^
  53 |   expect(error.message).toContain(`navigating to "${url}", waiting until "networkidle"`);
  54 | });
  55 |

    at D:\a\playwright\playwright\tests\page\frame-goto.spec.ts:52:25

Retry 2:

Error: expect(received).toContain(expected) // indexOf

Matcher error: received value must not be null nor undefined

Received has value: undefined

  50 |   const url = server.PREFIX + '/frames/child-redirect.html';
  51 |   const error = await page.goto(url, { timeout: 5000, waitUntil: 'networkidle' }).catch(e => e);
> 52 |   expect(error.message).toContain('page.goto: Timeout 5000ms exceeded.');
     |                         ^
  53 |   expect(error.message).toContain(`navigating to "${url}", waiting until "networkidle"`);
  54 | });
  55 |

    at D:\a\playwright\playwright\tests\page\frame-goto.spec.ts:52:25

Retry 3:

Error: expect(received).toContain(expected) // indexOf

Matcher error: received value must not be null nor undefined

Received has value: undefined

  50 |   const url = server.PREFIX + '/frames/child-redirect.html';
  51 |   const error = await page.goto(url, { timeout: 5000, waitUntil: 'networkidle' }).catch(e => e);
> 52 |   expect(error.message).toContain('page.goto: Timeout 5000ms exceeded.');
     |                         ^
  53 |   expect(error.message).toContain(`navigating to "${url}", waiting until "networkidle"`);
  54 | });
  55 |

    at D:\a\playwright\playwright\tests\page\frame-goto.spec.ts:52:25

[webkit] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

Error: expect(received).toBe(expected) // Object.is equality

Expected: "137"
Received: "null"

  66 |     if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) === 22) {
  67 |       // WebKit on mac13 exits differently.
> 68 |       expect(await remoteServer.out('exitCode')).toBe('137');
     |                                                  ^
  69 |       expect(await remoteServer.out('signal')).toBe('null');
  70 |     } else {
  71 |       expect(await remoteServer.out('exitCode')).toBe('null');

    at /Users/runner/work/playwright/playwright/tests/library/signals.spec.ts:68:50

Retry 1:

Error: expect(received).toBe(expected) // Object.is equality

Expected: "137"
Received: "null"

  66 |     if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) === 22) {
  67 |       // WebKit on mac13 exits differently.
> 68 |       expect(await remoteServer.out('exitCode')).toBe('137');
     |                                                  ^
  69 |       expect(await remoteServer.out('signal')).toBe('null');
  70 |     } else {
  71 |       expect(await remoteServer.out('exitCode')).toBe('null');

    at /Users/runner/work/playwright/playwright/tests/library/signals.spec.ts:68:50

Retry 2:

Error: expect(received).toBe(expected) // Object.is equality

Expected: "137"
Received: "null"

  66 |     if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) === 22) {
  67 |       // WebKit on mac13 exits differently.
> 68 |       expect(await remoteServer.out('exitCode')).toBe('137');
     |                                                  ^
  69 |       expect(await remoteServer.out('signal')).toBe('null');
  70 |     } else {
  71 |       expect(await remoteServer.out('exitCode')).toBe('null');

    at /Users/runner/work/playwright/playwright/tests/library/signals.spec.ts:68:50

Retry 3:

Error: expect(received).toBe(expected) // Object.is equality

Expected: "137"
Received: "null"

  66 |     if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) === 22) {
  67 |       // WebKit on mac13 exits differently.
> 68 |       expect(await remoteServer.out('exitCode')).toBe('137');
     |                                                  ^
  69 |       expect(await remoteServer.out('signal')).toBe('null');
  70 |     } else {
  71 |       expect(await remoteServer.out('exitCode')).toBe('null');

    at /Users/runner/work/playwright/playwright/tests/library/signals.spec.ts:68:50

Merge workflow run.

@mxschmitt mxschmitt merged commit 167165d into main Aug 10, 2023
90 of 97 checks passed
@mxschmitt mxschmitt deleted the roll-into-pw-chromium/1076 branch August 10, 2023 13:16
mxschmitt pushed a commit that referenced this pull request Aug 10, 2023
This PR cherry-picks the following commits:

- 167165d

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants