Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: use azcopy for better upload performance #26360

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Aug 9, 2023

The credentials are created with
az ad sp create-for-rbac --name "playwright-github-actions" --role "Storage Blob Data Contributor" --scopes /subscriptions/<subscription id>/resourceGroups/<resource group>/providers/Microsoft.Storage/storageAccounts/<storage account>

We cannot use azure/login@v1 for login as it does not see to properly propagate credentials to azcopy in the next step (there are some reports about keyring problems on linux based actions).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test results for "tests 1"

3 failed
❌ [playwright-test] › reporter-html.spec.ts:1452:7 › merged › labels › filter should update stats
❌ [playwright-test] › to-have-screenshot.spec.ts:62:5 › should disable animations by default
❌ [playwright-test] › ui-mode-test-progress.spec.ts:218:5 › should show trace w/ multiple contexts

8 flaky
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/page-goto.spec.ts:112:3 › should work with Cross-Origin-Opener-Policy after redirect
⚠️ [playwright-test] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events
⚠️ [chromium] › library/capabilities.spec.ts:139:3 › should not crash on showDirectoryPicker
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

25043 passed, 583 skipped
✔️✔️✔️

[playwright-test] › reporter-html.spec.ts:1452:7 › merged › labels › filter should update stats

Error: expect(received).toBe(expected) // Object.is equality

Expected: "Total time: 1369ms"
Received: "Total time: 1.4s"

  1774 |         await expect(page.locator('.chip', { hasText: 'c.test.js' })).toHaveCount(1);
  1775 |
> 1776 |         await flakyButton.click();
       |                                 ^
  1777 |
  1778 |         await expect(searchInput).toHaveValue('@regression @flaky');
  1779 |         await expect(page).toHaveURL(/@regression%20@flaky/);

    at checkTotalDuration (D:\a\playwright\playwright\tests\playwright-test\reporter-html.spec.ts:1776:33)
    at D:\a\playwright\playwright\tests\playwright-test\reporter-html.spec.ts:1782:9

[playwright-test] › to-have-screenshot.spec.ts:62:5 › should disable animations by default

Test timeout of 30000ms exceeded.

[playwright-test] › ui-mode-test-progress.spec.ts:218:5 › should show trace w/ multiple contexts

Error: action list

- Expected  - 5
+ Received  + 1

- Array [
-   /apiRequestContext.get[\d.]+m?s/,
-   /browserContext.newPage[\d.]+m?s/,
-   /page.gotoabout:blank[\d.]+m?s/,
- ]
+ Array []
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements


  240 |       listItem,
  241 |       'action list'
> 242 |   ).toHaveText([
      |     ^
  243 |     /apiRequestContext.get[\d.]+m?s/,
  244 |     /browserContext.newPage[\d.]+m?s/,
  245 |     /page.gotoabout:blank[\d.]+m?s/,

    at D:\a\playwright\playwright\tests\playwright-test\ui-mode-test-progress.spec.ts:242:5

Retry 1:

Error: action list

- Expected  - 5
+ Received  + 1

- Array [
-   /apiRequestContext.get[\d.]+m?s/,
-   /browserContext.newPage[\d.]+m?s/,
-   /page.gotoabout:blank[\d.]+m?s/,
- ]
+ Array []
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements


  240 |       listItem,
  241 |       'action list'
> 242 |   ).toHaveText([
      |     ^
  243 |     /apiRequestContext.get[\d.]+m?s/,
  244 |     /browserContext.newPage[\d.]+m?s/,
  245 |     /page.gotoabout:blank[\d.]+m?s/,

    at D:\a\playwright\playwright\tests\playwright-test\ui-mode-test-progress.spec.ts:242:5

Retry 2:

Error: action list

- Expected  - 5
+ Received  + 1

- Array [
-   /apiRequestContext.get[\d.]+m?s/,
-   /browserContext.newPage[\d.]+m?s/,
-   /page.gotoabout:blank[\d.]+m?s/,
- ]
+ Array []
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements


  240 |       listItem,
  241 |       'action list'
> 242 |   ).toHaveText([
      |     ^
  243 |     /apiRequestContext.get[\d.]+m?s/,
  244 |     /browserContext.newPage[\d.]+m?s/,
  245 |     /page.gotoabout:blank[\d.]+m?s/,

    at D:\a\playwright\playwright\tests\playwright-test\ui-mode-test-progress.spec.ts:242:5

Retry 3:

Error: action list

- Expected  - 5
+ Received  + 1

- Array [
-   /apiRequestContext.get[\d.]+m?s/,
-   /browserContext.newPage[\d.]+m?s/,
-   /page.gotoabout:blank[\d.]+m?s/,
- ]
+ Array []
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements


  240 |       listItem,
  241 |       'action list'
> 242 |   ).toHaveText([
      |     ^
  243 |     /apiRequestContext.get[\d.]+m?s/,
  244 |     /browserContext.newPage[\d.]+m?s/,
  245 |     /page.gotoabout:blank[\d.]+m?s/,

    at D:\a\playwright\playwright\tests\playwright-test\ui-mode-test-progress.spec.ts:242:5

Merge workflow run.

@yury-s yury-s merged commit ff0aef3 into microsoft:main Aug 9, 2023
27 of 28 checks passed
@yury-s yury-s deleted the azcopy branch August 9, 2023 05:50
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
The credentials are created with 
`az ad sp create-for-rbac --name "playwright-github-actions" --role
"Storage Blob Data Contributor" --scopes /subscriptions/<subscription
id>/resourceGroups/<resource
group>/providers/Microsoft.Storage/storageAccounts/<storage account>`

We cannot use `azure/login@v1` for login as it does not see to properly
propagate credentials to `azcopy` in the next step (there are some
reports about keyring problems on linux based actions).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants