Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eliminate race in compilation cache #26353

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix: eliminate race in compilation cache #26353

merged 2 commits into from
Aug 8, 2023

Conversation

aslushnikov
Copy link
Collaborator

Fixes #24569

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Test results for "tests 1"

11 flaky
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [playwright-test] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [webkit] › library/browsercontext-fetch.spec.ts:1039:3 › should abort requests when browser context closes
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events

25038 passed, 583 skipped
✔️✔️✔️

Merge workflow run.

@aslushnikov aslushnikov merged commit ffd6cf6 into microsoft:main Aug 8, 2023
28 checks passed
@aslushnikov aslushnikov deleted the fix-compilation-cache-race branch August 8, 2023 22:09
@p01
Copy link
Contributor

p01 commented Aug 9, 2023

Oh! Thank you 🙇🏻
This was starting to hit our pipelines significantly.

@aslushnikov
Copy link
Collaborator Author

@p01 we hope this will help, but we're not sure since we are not able to repro.

Let us know how it will work!

@aslushnikov aslushnikov mentioned this pull request Aug 31, 2023
Closed
@dgozman dgozman mentioned this pull request Oct 13, 2023
Merged
dgozman added a commit that referenced this pull request Oct 14, 2023
@dgozman
fix(test runner): rework compilation cache logic (#27607)
f016709 
- Do not write from workers.
- Remove marker files.
- Always try/catch reading from fs.

This mostly reverts #26830
and #26353.

Fixes #27592.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@aslushnikov @Germandrummer92
fix: eliminate race in compilation cache (microsoft#26353)
2ed9337 
Fixes microsoft#24569
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@dgozman @Germandrummer92
fix(test runner): rework compilation cache logic (microsoft#27607)
c3a9fc5 
- Do not write from workers.
- Remove marker files.
- Always try/catch reading from fs.

This mostly reverts microsoft#26830
and microsoft#26353.

Fixes microsoft#27592.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aslushnikov @p01 @dgozman