Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: do not collide with other tests when test names have special chars (#23414)" #24213

Merged
merged 1 commit into from Jul 13, 2023
Merged

Revert "fix: do not collide with other tests when test names have special chars (#23414)" #24213

merged 1 commit into from Jul 13, 2023

Conversation

mxschmitt
Copy link
Member

This reverts commit 4b1b4dc.

#24184

Reopens #23386

@mxschmitt mxschmitt merged commit 57cca1d into main Jul 13, 2023
26 checks passed
@mxschmitt mxschmitt deleted the revert-4b1b4dc23bd5e58a0d72e4d083f2a8fb8114fe85 branch July 13, 2023 18:03
@github-actions
Copy link
Contributor

Test results for "tests 1"

❌ failed: 0

⚠️ flaky: 8

  • [playwright-test-ubuntu-latest-node18] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live
  • [playwright-test-ubuntu-latest-node16] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live
  • [playwright-test-macos-latest-node16] › ui-mode-trace.spec.ts:22:5 › should merge trace events
  • [chromium-ubuntu-22.04-node18] › library/tracing.spec.ts:429:5 › should work with multiple chunks
  • [chromium-ubuntu-22.04-node16] › page/page-event-request.spec.ts:129:3 › should report navigation requests and responses handled by service worker with routing
  • [firefox-ubuntu-22.04-node16] › library/tracing.spec.ts:706:5 › should not emit after w/o before
  • [chromium-ubuntu-22.04-node20] › library/tracing.spec.ts:239:5 › should not include trace resources from the provious chunks
  • [webkit-ubuntu-22.04-node16] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

☑️ skipped: 509

✅ passed: 21631

Full html report.

github-actions bot added a commit that referenced this pull request Jul 13, 2023
@github-actions
cherry-pick(#24213): Revert "fix: do not collide with other tests whe…
b4215e3 
…n test names have special chars (#23414)"
aslushnikov pushed a commit that referenced this pull request Jul 14, 2023
@playwrightmachine @github-actions
cherry-pick(#24213): Revert "fix: do not collide with other tests whe…
cf5900f 
…n test names have special chars (#23414)" (#24217)

This PR cherry-picks the following commits:

- 57cca1d

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@mxschmitt @Germandrummer92
Revert "fix: do not collide with other tests when test names have spe…
e478f49 
…cial chars (microsoft#23414)" (microsoft#24213)

This reverts commit 4b1b4dc.

microsoft#24184

Reopens microsoft#23386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxschmitt @dgozman