update newBinaryCmd URL path handling
#2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows UNC paths weren't properly handled by `filepath.Clean` and this behavior was fixed in golang/go@be9d78c For a binary URL `binary:///\executable`, the `URL.Path` will be `/\executable` and `filepath.Clean` will now return `\\executable`, which previously would return `\executable`. In the case of binary logger, it'd be safer to not accept UNC paths, so this PR adds a short circuit when the clean path starts with `\\`. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
update-binary-cmd
branch
from
182ea54
to
ceb2ef5
Compare
kiashok
approved these changes
Feb 28, 2024
anmaxvl
added a commit
that referenced
this pull request
Mar 1, 2024
Signed-off-by: Maksim An <maksiman@microsoft.com>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Mar 1, 2024
Signed-off-by: Maksim An <maksiman@microsoft.com>
kiashok
pushed a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Maksim An <maksiman@microsoft.com>
kiashok
pushed a commit
that referenced
this pull request
Mar 5, 2024
Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows UNC paths weren't properly handled by
filepath.Cleanand this behavior was fixed ingolang/go@be9d78c
For a binary URL
binary:///\executable, theURL.Pathwill be/\executableandfilepath.Cleanwill now return
\\executable, which previously would return\executable.In the case of binary logger, it'd be safer to not accept UNC paths, so this PR adds a
short circuit when the clean path starts with
\\.