Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mounting multiple dev nodes per assigned device #2003

Conversation

katiewasnothere
Copy link
Contributor

This PR updates support assigned devices to allow for finding multiple dev nodes (under /dev) that correspond to an assigned device.

Example scenario, nvidia gpu kernel modules create the following dev nodes that need to be present in a container to interact with the GPU:

  • /dev/nvidiaX (where X is the index of the GPU)
  • /dev/nvidia-uvm
  • /dev/nvidiactl
  • /dev/nvidia-uvm-tools

@katiewasnothere katiewasnothere requested a review from a team as a code owner January 20, 2024 01:39
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, comment aside

internal/guest/runtime/hcsv2/spec_devices.go Show resolved Hide resolved
… corresponding to device

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere katiewasnothere force-pushed the kabaldau/assigned_devices_return_multi branch from c6f17f8 to 32b760c Compare February 14, 2024 21:44
@katiewasnothere katiewasnothere merged commit 40f4a91 into microsoft:main Feb 14, 2024
18 of 19 checks passed
@katiewasnothere katiewasnothere deleted the kabaldau/assigned_devices_return_multi branch February 14, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants