Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.5
Choose a base ref
...
head repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.6
Choose a head ref
  • 6 commits
  • 1,322 files changed
  • 3 contributors

Commits on Aug 19, 2024

  1. Omnibus dependency update (#2166)

    Dependebot PRs:
    
     - hcsshim/2140
     - hcsshim/2145
     - hcsshim/2146
     - hcsshim/2149
     - hcsshim/2153
     - hcsshim/2154
     - hcsshim/2159
     - hcsshim/2161
     - hcsshim/2174
     - hcsshim/2175
     - hcsshim/2176
    
    Update protobuf files.
    
    `google.golang.org/grpc v1.64.0` deprecated `Dial[Context]` and
    `WithBlock`.
    Replacing either is non-trivial, and left for a future PR.
    
    Update dependabot file to ignore patch updates: they rarely provide bug
    fixes and increase repo churn.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    (cherry picked from commit 75428d1)
    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    helsaawy authored and kiashok committed Aug 19, 2024
    Copy the full SHA
    4f46058 View commit details
  2. Upgrade deps to resolve CVEs (#2225)

    CVE alerts:
    
     - https://github.com/microsoft/hcsshim/security/dependabot/108
     - https://github.com/microsoft/hcsshim/security/dependabot/107
    
    Dependabot PRs:
    
     - 2224
     - 2223
     - 2219
     - 2218
     - 2213
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    (cherry picked from commit a8ef0c4)
    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    helsaawy authored and kiashok committed Aug 19, 2024
    Copy the full SHA
    6a5ebd3 View commit details
  3. Bump opa/containerd to latest versions

    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    (cherry picked from commit 88ac0d9)
    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    kiashok committed Aug 19, 2024
    Copy the full SHA
    d4b1cc0 View commit details
  4. drop usage of deprecated package/methods

    Signed-off-by: Davanum Srinivas <davanum@gmail.com>
    (cherry picked from commit 56e8cf9)
    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    dims authored and kiashok committed Aug 19, 2024
    Copy the full SHA
    85a5a57 View commit details
  5. Update module versions

    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    kiashok committed Aug 19, 2024
    Copy the full SHA
    7d25ce2 View commit details
  6. Omnibus dependency updates (#2051)

    Consolidate dependabot updates:
     - github.com//pull/2050
     - github.com//pull/2048
     - github.com//pull/2047
     - github.com//pull/2046
     - github.com//pull/2045
     - github.com//pull/2044
     - github.com//pull/2043
     - github.com//pull/2042
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    (cherry picked from commit 060de7c)
    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    helsaawy authored and kiashok committed Aug 19, 2024
    Copy the full SHA
    f922f2a View commit details
Showing 1,322 changed files with 358,628 additions and 36,616 deletions.
4 changes: 3 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -15,6 +15,9 @@ updates:
# only do patch updates for containerd and co: don't bump anything else
- dependency-name: "github.com/containerd/*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
# ignore patch version increment updates to avoid churn
- dependency-name: "*"
update-types: ["version-update:semver-patch"]
# allow more PRs to clear queue faster
open-pull-requests-limit: 10

@@ -30,7 +33,6 @@ updates:
ignore:
# keep containerd and related dependencies in sync with the shim/the root repo
- dependency-name: "github.com/containerd/*"
# ignore patch version increment updates in test; they shouldn't be critical
- dependency-name: "*"
update-types: ["version-update:semver-patch"]
open-pull-requests-limit: 5
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -80,7 +80,7 @@ jobs:
- name: Install protoc
shell: powershell
run: |
gh release download -R protocolbuffers/protobuf -p 'protoc-*-win32.zip' -O protoc.zip 'v23.2'
gh release download -R protocolbuffers/protobuf -p 'protoc-*-win32.zip' -O protoc.zip 'v26.0'
if ( $LASTEXITCODE ) {
Write-Output '::error::Could not download protoc.'
exit $LASTEXITCODE
10 changes: 5 additions & 5 deletions cmd/containerd-shim-runhcs-v1/options/runhcs.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions cmd/containerd-shim-runhcs-v1/stats/stats.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions cmd/ncproxy/run.go
Original file line number Diff line number Diff line change
@@ -232,8 +232,12 @@ func run(clicontext *cli.Context) error {
var cancel context.CancelFunc
dialCtx, cancel = context.WithTimeout(ctx, time.Duration(conf.Timeout)*time.Second)
defer cancel()
//nolint:staticcheck // SA1019: grpc.WithBlock is deprecated
opts = append(opts, grpc.WithBlock())
}

// TODO: use grpc.NewClient here instead
//nolint:staticcheck // SA1019: grpc.DialContext is deprecated, replace with grpc.NewClient
client, err := grpc.DialContext(dialCtx, conf.NodeNetSvcAddr, opts...)
if err != nil {
return fmt.Errorf("failed to connect to NodeNetworkService at address %s", conf.NodeNetSvcAddr)
80 changes: 50 additions & 30 deletions go.mod
Original file line number Diff line number Diff line change
@@ -4,97 +4,117 @@ go 1.21

require (
github.com/Microsoft/cosesign1go v1.1.0
github.com/Microsoft/didx509go v0.0.2
github.com/Microsoft/didx509go v0.0.3
github.com/Microsoft/go-winio v0.6.2
github.com/blang/semver/v4 v4.0.0
github.com/cenkalti/backoff/v4 v4.2.1
github.com/containerd/cgroups/v3 v3.0.2
github.com/containerd/console v1.0.3
github.com/containerd/containerd v1.7.18
github.com/cenkalti/backoff/v4 v4.3.0
github.com/containerd/cgroups/v3 v3.0.3
github.com/containerd/console v1.0.4
github.com/containerd/containerd v1.7.20
github.com/containerd/containerd/api v1.7.19
github.com/containerd/errdefs v0.1.0
github.com/containerd/go-runc v1.0.0
github.com/containerd/protobuild v0.3.0
github.com/containerd/ttrpc v1.2.4
github.com/containerd/ttrpc v1.2.5
github.com/containerd/typeurl/v2 v2.1.1
github.com/google/go-cmp v0.6.0
github.com/google/go-containerregistry v0.17.0
github.com/google/go-containerregistry v0.20.1
github.com/josephspurrier/goversioninfo v1.4.0
github.com/linuxkit/virtsock v0.0.0-20201010232012-f8cee7dfc7a3
github.com/mattn/go-shellwords v1.0.12
github.com/open-policy-agent/opa v0.42.2
github.com/open-policy-agent/opa v0.67.1
github.com/opencontainers/runc v1.1.12
github.com/opencontainers/runtime-spec v1.1.0
github.com/opencontainers/runtime-spec v1.2.0
github.com/pelletier/go-toml v1.9.5
github.com/pkg/errors v0.9.1
github.com/sirupsen/logrus v1.9.3
github.com/urfave/cli v1.22.14
github.com/urfave/cli v1.22.15
github.com/vishvananda/netlink v1.2.1-beta.2
github.com/vishvananda/netns v0.0.4
go.etcd.io/bbolt v1.3.9
go.etcd.io/bbolt v1.3.10
go.opencensus.io v0.24.0
go.uber.org/mock v0.4.0
golang.org/x/exp v0.0.0-20231006140011-7918f672742d
golang.org/x/sync v0.6.0
golang.org/x/sys v0.18.0
google.golang.org/grpc v1.62.0
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
google.golang.org/protobuf v1.33.0
golang.org/x/sync v0.7.0
golang.org/x/sys v0.23.0
google.golang.org/grpc v1.65.0
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1
google.golang.org/protobuf v1.34.2
)

require (
github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect
github.com/OneOfOne/xxhash v1.2.8 // indirect
github.com/agnivade/levenshtein v1.0.1 // indirect
github.com/agnivade/levenshtein v1.1.1 // indirect
github.com/akavel/rsrc v0.10.2 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/containerd/continuity v0.4.2 // indirect
github.com/containerd/fifo v1.1.0 // indirect
github.com/containerd/log v0.1.0 // indirect
github.com/containerd/stargz-snapshotter/estargz v0.14.3 // indirect
github.com/coreos/go-systemd/v22 v22.5.0 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.4 // indirect
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.2.0 // indirect
github.com/distribution/reference v0.6.0 // indirect
github.com/docker/cli v24.0.0+incompatible // indirect
github.com/docker/distribution v2.8.2+incompatible // indirect
github.com/docker/docker v24.0.7+incompatible // indirect
github.com/docker/docker v27.1.1+incompatible // indirect
github.com/docker/docker-credential-helpers v0.7.0 // indirect
github.com/docker/go-connections v0.4.0 // indirect
github.com/docker/go-events v0.0.0-20190806004212-e31b211e4f1c // indirect
github.com/docker/go-units v0.5.0 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fxamacker/cbor/v2 v2.4.0 // indirect
github.com/ghodss/yaml v1.0.0 // indirect
github.com/go-ini/ini v1.67.0 // indirect
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/gobwas/glob v0.2.3 // indirect
github.com/goccy/go-json v0.10.2 // indirect
github.com/godbus/dbus/v5 v5.1.0 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/klauspost/compress v1.16.5 // indirect
github.com/kr/pretty v0.3.0 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/gorilla/mux v1.8.1 // indirect
github.com/klauspost/compress v1.17.0 // indirect
github.com/lestrrat-go/backoff/v2 v2.0.8 // indirect
github.com/lestrrat-go/blackmagic v1.0.2 // indirect
github.com/lestrrat-go/httpcc v1.0.1 // indirect
github.com/lestrrat-go/iter v1.0.2 // indirect
github.com/lestrrat-go/jwx v1.2.28 // indirect
github.com/lestrrat-go/option v1.0.1 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/moby/docker-image-spec v1.3.1 // indirect
github.com/moby/sys/mountinfo v0.6.2 // indirect
github.com/moby/sys/sequential v0.5.0 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.1.0 // indirect
github.com/prometheus/client_golang v1.19.1 // indirect
github.com/prometheus/client_model v0.6.1 // indirect
github.com/prometheus/common v0.48.0 // indirect
github.com/prometheus/procfs v0.12.0 // indirect
github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 // indirect
github.com/russross/blackfriday/v2 v2.1.0 // indirect
github.com/tchap/go-patricia/v2 v2.3.1 // indirect
github.com/vbatts/tar-split v0.11.3 // indirect
github.com/vektah/gqlparser/v2 v2.4.5 // indirect
github.com/veraison/go-cose v1.2.0 // indirect
github.com/x448/float16 v0.8.4 // indirect
github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb // indirect
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect
github.com/yashtewari/glob-intersection v0.1.0 // indirect
golang.org/x/crypto v0.21.0 // indirect
golang.org/x/mod v0.13.0 // indirect
golang.org/x/net v0.23.0 // indirect
golang.org/x/text v0.14.0 // indirect
golang.org/x/tools v0.14.0 // indirect
github.com/yashtewari/glob-intersection v0.2.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.53.0 // indirect
go.opentelemetry.io/otel v1.28.0 // indirect
go.opentelemetry.io/otel/metric v1.28.0 // indirect
go.opentelemetry.io/otel/sdk v1.28.0 // indirect
go.opentelemetry.io/otel/trace v1.28.0 // indirect
golang.org/x/crypto v0.25.0 // indirect
golang.org/x/mod v0.17.0 // indirect
golang.org/x/net v0.27.0 // indirect
golang.org/x/text v0.16.0 // indirect
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
google.golang.org/genproto v0.0.0-20240123012728-ef4313101c80 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240123012728-ef4313101c80 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240701130421-f6361c86f094 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
sigs.k8s.io/yaml v1.4.0 // indirect
)
Loading