Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use npm to run postinstall scripts #4611

Merged
merged 1 commit into from Jan 29, 2024
Merged

fix: Use npm to run postinstall scripts #4611

merged 1 commit into from Jan 29, 2024

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Jan 29, 2024 •
edited by tracyboehrer

Fixes #4610

Description

This PR replaces yarn with npm to execute the postinstall scripts.

Specific Changes

  • Replaced yarn command with npm run command in botbuilder-dialogs and botbuilder-dialogs-adaptive

Testing

The following image shows the postinstall script working with npm run.
image

@JhontSouth JhontSouth requested a review from a team as a code owner January 29, 2024 15:28
@coveralls
Copy link

coveralls commented Jan 29, 2024 •
edited

Pull Request Test Coverage Report for Build 7698453893

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.48%
Totals Coverage Status
Change from base Build 7641852693: 0.0%
Covered Lines: 20414
Relevant Lines: 22880
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 6005780 into main Jan 29, 2024
14 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/use-npm-postintall-scripts branch January 29, 2024 19:02
tracyboehrer pushed a commit that referenced this pull request Jan 29, 2024
@JhontSouth
use npm to run postinstall scripts (#4611)
581156b
@andrewconnell
Copy link

@andrewconnell andrewconnell mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'yarn' command not found while installing 'botbuilder-dialogs'
4 participants
@JhontSouth @coveralls @andrewconnell @tracyboehrer