chore: Fix test irregularities #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 73.70% 74.82% +1.12%
==========================================
Files 398 423 +25
Lines 12046 13093 +1047
==========================================
+ Hits 8878 9797 +919
- Misses 3168 3296 +128
|
codeofdusk
changed the title
codeofdusk
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Similar to microsoft/accessibility-insights-windows#1687, there are some irregularities in our test decorators. This PR is made up of the following global search & replace operations:
[TestClass()]becomes[TestClass][TestMethod()]becomes[TestMethod]The extra parentheses on the decorators don't break anything, but they are non-standard and don't add any value. I've confirmed that all unit tests run as expected.
Motivation
Code consistency
Context
Pull request checklist