New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable scanning of chromium content #967
Merged
DaveTryon
merged 7 commits into
microsoft:main
from
DaveTryon:enable-scanning-of-chromium-content
Sep 1, 2023
Merged
feat: Enable scanning of chromium content #967
DaveTryon
merged 7 commits into
microsoft:main
from
DaveTryon:enable-scanning-of-chromium-content
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #967 +/- ##
==========================================
+ Coverage 73.70% 74.88% +1.18%
==========================================
Files 398 424 +26
Lines 12046 13117 +1071
==========================================
+ Hits 8878 9823 +945
- Misses 3168 3294 +126
|
codeofdusk
reviewed
Sep 1, 2023
codeofdusk
approved these changes
Sep 1, 2023
DaveTryon
added a commit
that referenced
this pull request
Sep 8, 2023
#### Details #967 added new functionality, so our next release ought to reflect this. This moves from 2.2.1 to 2.3.0 ##### Motivation Follow semver guidelines ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In #951, we intentionally excluded all elements inside a Chromium document from scan results. This makes sense for most developers, since the conversion from HTML to UIA is convoluted and outside the control of the HTML developer. However, the Edge team relies on this functionality to help improve their HTML-to-UIA conversion code. This PR defaults to excluding the elements inside a Chromium document, but adds a way to request that scan results include elements within a Chromium document. This option is exposed in 3 places:
Automation
layerSelectAction
class (for future use from Accessibility Insights for Windows)Motivation
Requested by the Edge team
Results
Comparison.zip contains
Default.a11ytest
andWithChromiumContent.a11ytest
, which were captured by running the CLI on the same instance of Edge. The rule comparison is as follows:The elements that are unique to the WithChromiumContent file are all within the Chromium document
Screenshots
Context
Actions
project didn't previously reference theRules
project directly, so the plumbing may be non-ideal. If we were to use the existing dependencies,Actions
would call intoDesktop
, which would call intoRuleSelection
, which would call intoRules
. We can add the 2 missing layers if we think there's value there.Pull request checklist