chore: Pin Moq to 4.18.4 #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeofdusk
reviewed
Aug 23, 2023
| @@ -27,14 +27,12 @@ | |||
| <!-- This target could be placed in any project which references the CodeCov package --> | |||
|
|
|||
| <ItemGroup> | |||
| <ReferenceToCodeCovPackage Include="@(PackageReference)" | |||
| Condition="'%(Identity)' == 'Codecov'" /> | |||
| <ReferenceToCodeCovPackage Include="@(PackageReference)" Condition="'%(Identity)' == 'Codecov'" /> | |||
There was a problem hiding this comment.
Does this look visually okay as just one line?
codeofdusk
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Since 4.20.x, Moq has introduced a privacy vulnerability that improperly handles user data. https://github.com/moq/moq/issues/1372
This pins to 4.18.4 until we can confirm that those privacy concerns are resolved.
Motivation
Privacy/Security
Context
Pull request checklist