Fix constraints of nested homomorphic mapped type instantiations #58098

ahejlsberg · 2024-04-06T21:21:29Z

ahejlsberg · 2024-04-06T21:21:45Z

typescript-bot · 2024-04-06T21:21:49Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-06T21:42:12Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-06T21:49:09Z

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/58098/merge:

Everything looks good!

typescript-bot · 2024-04-06T21:55:13Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,766k (± 0.01%)}	_{295,774k (± 0.01%)}	_~	_295,741k	_295,849k	_{p=0.630 n=6}
_{Parse Time}	_{2.65s (± 0.31%)}	_{2.66s (± 0.58%)}	_~	_2.63s	_2.67s	_{p=0.154 n=6}
_{Bind Time}	_{0.82s (± 1.62%)}	_{0.82s (± 1.50%)}	_~	_0.81s	_0.84s	_{p=0.389 n=6}
_{Check Time}	_{8.20s (± 0.37%)}	_{8.21s (± 0.36%)}	_~	_8.18s	_8.25s	_{p=0.567 n=6}
_{Emit Time}	_{7.04s (± 0.17%)}	_{7.04s (± 0.17%)}	_~	_7.03s	_7.06s	_{p=0.677 n=6}
_{Total Time}	_{18.72s (± 0.22%)}	_{18.73s (± 0.13%)}	_~	_18.69s	_18.76s	_{p=0.871 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,465k (± 1.03%)}	_{192,851k (± 0.96%)}	_~	_191,610k	_195,354k	_{p=0.521 n=6}
_{Parse Time}	_{1.36s (± 1.08%)}	_{1.36s (± 0.80%)}	_~	_1.35s	_1.38s	_{p=0.803 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.39s (± 0.09%)}	_{9.40s (± 0.28%)}	_~	_9.38s	_9.45s	_{p=0.682 n=6}
_{Emit Time}	_{2.63s (± 0.40%)}	_{2.61s (± 0.66%)}	_~	_2.59s	_2.63s	_{p=0.217 n=6}
_{Total Time}	_{14.09s (± 0.15%)}	_{14.09s (± 0.23%)}	_~	_14.06s	_14.15s	_{p=0.685 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,684k (± 0.00%)}	_{347,675k (± 0.01%)}	_~	_347,650k	_347,713k	_{p=0.378 n=6}
_{Parse Time}	_{2.48s (± 0.57%)}	_{2.49s (± 0.47%)}	_~	_2.47s	_2.50s	_{p=0.325 n=6}
_{Bind Time}	_{0.89s (± 0.58%)}	_{0.89s (± 0.46%)}	_~	_0.89s	_0.90s	_{p=0.595 n=6}
_{Check Time}	_{6.94s (± 0.54%)}	_{6.96s (± 0.52%)}	_~	_6.91s	_7.00s	_{p=0.627 n=6}
_{Emit Time}	_{4.06s (± 0.58%)}	_{4.07s (± 0.42%)}	_~	_4.05s	_4.09s	_{p=0.515 n=6}
_{Total Time}	_{14.38s (± 0.38%)}	_{14.40s (± 0.39%)}	_~	_14.34s	_14.48s	_{p=0.294 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,560k (± 0.01%)}	_{302,545k (± 0.01%)}	_~	_302,527k	_302,574k	_{p=0.199 n=6}
_{Parse Time}	_{2.96s (± 0.78%)}	_{2.96s (± 0.94%)}	_~	_2.94s	_3.01s	_{p=0.808 n=6}
_{Bind Time}	_{1.44s (± 0.92%)}	_{1.43s (± 0.93%)}	_~	_1.41s	_1.45s	_{p=0.498 n=6}
_{Check Time}	_{9.18s (± 0.47%)}	_{9.15s (± 0.20%)}	_~	_9.13s	_9.18s	_{p=0.148 n=6}
_{Emit Time}	_{5.30s (± 0.82%)}	_{5.30s (± 0.58%)}	_~	_5.25s	_5.33s	_{p=0.746 n=6}
_{Total Time}	_{18.89s (± 0.48%)}	_{18.85s (± 0.21%)}	_~	_18.81s	_18.92s	_{p=0.336 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,517k (± 0.00%)}	_{510,509k (± 0.01%)}	_~	_510,449k	_510,558k	_{p=0.936 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.67s (± 0.39%)}	_~	_2.66s	_2.68s	_{p=0.293 n=6}
_{Bind Time}	_{0.99s (± 0.99%)}	_{0.99s (± 0.52%)}	_~	_0.98s	_0.99s	_{p=0.386 n=6}
_{Check Time}	_{17.15s (± 0.24%)}	_{17.22s (± 0.32%)}	_~	_17.15s	_17.28s	_{p=0.076 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.81s (± 0.23%)}	_{20.87s (± 0.31%)}	_~	_20.79s	_20.94s	_{p=0.260 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,743,829k (± 0.00%)}	_{1,743,873k (± 0.00%)}	_{+44k (+ 0.00%)}	_1,743,818k	_1,743,911k	_{p=0.045 n=6}
_{Parse Time}	_{9.65s (± 0.75%)}	_{9.65s (± 0.52%)}	_~	_9.57s	_9.70s	_{p=0.873 n=6}
_{Bind Time}	_{3.40s (± 0.71%)}	_{3.40s (± 0.99%)}	_~	_3.36s	_3.44s	_{p=0.746 n=6}
_{Check Time}	_{81.16s (± 0.26%)}	_{81.35s (± 0.38%)}	_~	_80.93s	_81.65s	_{p=0.230 n=6}
_{Emit Time}	_{0.19s (± 2.13%)}	_{0.19s (± 0.00%)}	_~	_0.19s	_0.19s	_{p=0.405 n=6}
_{Total Time}	_{94.42s (± 0.27%)}	_{94.59s (± 0.32%)}	_~	_94.22s	_94.96s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,299,594k (± 0.04%)}	_{2,299,470k (± 0.02%)}	_~	_2,298,906k	_2,299,854k	_{p=0.810 n=6}
_{Parse Time}	_{7.41s (± 0.95%)}	_{7.43s (± 0.46%)}	_~	_7.38s	_7.48s	_{p=0.520 n=6}
_{Bind Time}	_{2.70s (± 0.83%)}	_{2.73s (± 0.77%)}	_~	_2.70s	_2.75s	_{p=0.109 n=6}
_{Check Time}	_{48.74s (± 0.52%)}	_{48.62s (± 0.42%)}	_~	_48.29s	_48.93s	_{p=0.521 n=6}
_{Emit Time}	_{3.86s (± 2.64%)}	_{3.78s (± 2.59%)}	_~	_3.65s	_3.89s	_{p=0.173 n=6}
_{Total Time}	_{62.74s (± 0.57%)}	_{62.58s (± 0.28%)}	_~	_62.37s	_62.81s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,373,596k (± 0.03%)}	_{2,374,419k (± 0.03%)}	_~	_2,373,237k	_2,375,150k	_{p=0.093 n=6}
_{Parse Time}	_{6.20s (± 0.96%)}	_{6.19s (± 1.45%)}	_~	_6.07s	_6.30s	_{p=0.936 n=6}
_{Bind Time}	_{2.03s (± 0.31%)}	_{2.04s (± 0.80%)}	_~	_2.02s	_2.06s	_{p=0.212 n=6}
_{Check Time}	_{39.93s (± 0.59%)}	_{39.79s (± 0.31%)}	_~	_39.55s	_39.88s	_{p=0.810 n=6}
_{Emit Time}	_{3.21s (± 1.78%)}	_{3.12s (± 2.59%)}	_~	_3.06s	_3.28s	_{p=0.128 n=6}
_{Total Time}	_{51.37s (± 0.49%)}	_{51.14s (± 0.41%)}	_~	_50.90s	_51.49s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,079k (± 0.01%)}	_{418,088k (± 0.01%)}	_~	_418,069k	_418,147k	_{p=0.471 n=6}
_{Parse Time}	_{4.13s (± 0.25%)}	_{4.13s (± 0.37%)}	_~	_4.12s	_4.16s	_{p=0.397 n=6}
_{Bind Time}	_{1.60s (± 1.23%)}	_{1.58s (± 1.46%)}	_~	_1.55s	_1.61s	_{p=0.123 n=6}
_{Check Time}	_{21.97s (± 0.40%)}	_{21.96s (± 0.33%)}	_~	_21.87s	_22.06s	_{p=1.000 n=6}
_{Emit Time}	_{1.70s (± 1.69%)}	_{1.72s (± 1.62%)}	_~	_1.69s	_1.76s	_{p=0.334 n=6}
_{Total Time}	_{29.41s (± 0.33%)}	_{29.39s (± 0.19%)}	_~	_29.32s	_29.46s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,905,115k (± 0.00%)}	_{2,905,131k (± 0.00%)}	_~	_2,905,056k	_2,905,191k	_{p=0.471 n=6}
_{Parse Time}	_{15.92s (± 0.48%)}	_{15.94s (± 0.34%)}	_~	_15.88s	_16.00s	_{p=0.809 n=6}
_{Bind Time}	_{4.94s (± 0.37%)}	_{4.91s (± 0.27%)}	_{-0.03s (- 0.61%)}	_4.89s	_4.93s	_{p=0.018 n=6}
_{Check Time}	_{86.63s (± 0.41%)}	_{86.45s (± 0.20%)}	_~	_86.22s	_86.69s	_{p=0.471 n=6}
_{Emit Time}	_{23.85s (± 0.65%)}	_{23.73s (± 0.37%)}	_~	_23.58s	_23.83s	_{p=0.336 n=6}
_{Total Time}	_{131.33s (± 0.30%)}	_{131.03s (± 0.12%)}	_~	_130.86s	_131.25s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,700k (± 0.01%)}	_{408,685k (± 0.01%)}	_~	_408,632k	_408,722k	_{p=0.575 n=6}
_{Parse Time}	_{4.79s (± 0.76%)}	_{4.81s (± 0.71%)}	_~	_4.76s	_4.86s	_{p=0.295 n=6}
_{Bind Time}	_{2.03s (± 1.05%)}	_{2.04s (± 0.88%)}	_~	_2.01s	_2.06s	_{p=0.415 n=6}
_{Check Time}	_{20.69s (± 0.30%)}	_{20.65s (± 0.22%)}	_~	_20.59s	_20.71s	_{p=0.297 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.51s (± 0.19%)}	_{27.51s (± 0.22%)}	_~	_27.42s	_27.60s	_{p=0.936 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{514,406k (± 0.02%)}	_{514,384k (± 0.02%)}	_~	_514,304k	_514,598k	_{p=0.810 n=6}
_{Parse Time}	_{4.89s (± 0.34%)}	_{4.90s (± 0.61%)}	_~	_4.86s	_4.95s	_{p=0.469 n=6}
_{Bind Time}	_{2.30s (± 0.73%)}	_{2.29s (± 0.98%)}	_~	_2.27s	_2.32s	_{p=0.742 n=6}
_{Check Time}	_{4.23s (± 1.06%)}	_{4.24s (± 0.19%)}	_~	_4.23s	_4.25s	_{p=0.572 n=6}
_{Emit Time}	_{0.11s (± 4.55%)}	_{0.12s (± 4.42%)}	_~	_0.11s	_0.12s	_{p=0.311 n=6}
_{Total Time}	_{11.54s (± 0.42%)}	_{11.55s (± 0.30%)}	_~	_11.51s	_11.60s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-06T23:07:03Z

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/58098/merge:

Everything looks good!

jakebailey · 2024-04-08T18:02:50Z

@typescript-bot cherry-pick this to release-5.4

typescript-bot · 2024-04-08T18:02:52Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.4`	✅ Started	✅ Results

typescript-bot · 2024-04-08T18:13:46Z

Hey, @jakebailey! I've created #58118 for you. This involved updating baselines; please check the diff.

…e-5.4 (#58118) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

ahejlsberg added 3 commits April 6, 2024 14:18

Rework getResolvedApparentTypeOfMappedType

8c4c985

Accept new baselines

f42d43a

Add regression test

c47afa6

typescript-bot assigned ahejlsberg Apr 6, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 6, 2024

ahejlsberg mentioned this pull request Apr 6, 2024

Improve apparent type of mapped types with mapped type modifiers #58091

Closed

Merge branch 'main' into fix58060

51bb424

Accept new baselines

dc966c2

ahejlsberg requested review from RyanCavanaugh and jakebailey April 6, 2024 22:20

jakebailey approved these changes Apr 8, 2024

View reviewed changes

typescript-bot mentioned this pull request Apr 8, 2024

🤖 Pick PR #58098 (Fix constraints of nested homomorph...) into release-5.4 #58118

Merged

ahejlsberg merged commit 066773b into main Apr 8, 2024
25 checks passed

ahejlsberg deleted the fix58060 branch April 8, 2024 23:02

DanielRosenwasser pushed a commit that referenced this pull request Apr 10, 2024

🤖 Pick PR #58098 (Fix constraints of nested homomorph...) into releas…

9f33bf1

…e-5.4 (#58118) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix constraints of nested homomorphic mapped type instantiations #58098

Fix constraints of nested homomorphic mapped type instantiations #58098

ahejlsberg commented Apr 6, 2024

ahejlsberg commented Apr 6, 2024

typescript-bot commented Apr 6, 2024 •

edited

typescript-bot commented Apr 6, 2024

typescript-bot commented Apr 6, 2024

typescript-bot commented Apr 6, 2024

tsc

typescript-bot commented Apr 6, 2024

jakebailey commented Apr 8, 2024

typescript-bot commented Apr 8, 2024 •

edited

typescript-bot commented Apr 8, 2024

Fix constraints of nested homomorphic mapped type instantiations #58098

Fix constraints of nested homomorphic mapped type instantiations #58098

Conversation

ahejlsberg commented Apr 6, 2024

ahejlsberg commented Apr 6, 2024

typescript-bot commented Apr 6, 2024 • edited

typescript-bot commented Apr 6, 2024

typescript-bot commented Apr 6, 2024

typescript-bot commented Apr 6, 2024

tsc

typescript-bot commented Apr 6, 2024

jakebailey commented Apr 8, 2024

typescript-bot commented Apr 8, 2024 • edited

typescript-bot commented Apr 8, 2024

typescript-bot commented Apr 6, 2024 •

edited

typescript-bot commented Apr 8, 2024 •

edited