Exclude generic string-like types from intersection reduction #57751

ahejlsberg · 2024-03-12T19:08:07Z

ahejlsberg · 2024-03-12T19:10:07Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2024-03-12T19:10:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-03-12T19:33:08Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-03-12T19:40:26Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/57751/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

RyanCavanaugh · 2024-03-12T19:53:05Z

@typescript-bot cherry-pick this to release-5.4

typescript-bot · 2024-03-12T19:53:08Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.4`	✅ Started	✅ Results

typescript-bot · 2024-03-12T19:55:35Z

Hey, @RyanCavanaugh! I've created #57753 for you.

typescript-bot · 2024-03-12T20:14:14Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/57751/merge:

Everything looks good!

typescript-bot · 2024-03-12T20:33:37Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,588k (± 0.00%)}	_{295,595k (± 0.01%)}	_~	_295,534k	_295,617k	_{p=0.128 n=6}
_{Parse Time}	_{2.66s (± 0.00%)}	_{2.66s (± 0.31%)}	_~	_2.65s	_2.67s	_{p=0.290 n=6}
_{Bind Time}	_{0.83s (± 0.76%)}	_{0.83s (± 1.08%)}	_~	_0.82s	_0.84s	_{p=1.000 n=6}
_{Check Time}	_{8.21s (± 0.21%)}	_{8.20s (± 0.53%)}	_~	_8.14s	_8.26s	_{p=0.469 n=6}
_{Emit Time}	_{7.13s (± 0.31%)}	_{7.14s (± 0.18%)}	_~	_7.13s	_7.16s	_{p=0.405 n=6}
_{Total Time}	_{18.83s (± 0.15%)}	_{18.83s (± 0.24%)}	_~	_18.77s	_18.90s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,039k (± 0.74%)}	_{192,133k (± 0.72%)}	_~	_191,383k	_194,925k	_{p=0.471 n=6}
_{Parse Time}	_{1.36s (± 0.89%)}	_{1.35s (± 0.87%)}	_~	_1.33s	_1.36s	_{p=0.438 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.29s (± 0.26%)}	_{9.34s (± 0.48%)}	_~	_9.30s	_9.42s	_{p=0.077 n=6}
_{Emit Time}	_{2.60s (± 0.38%)}	_{2.60s (± 0.21%)}	_~	_2.60s	_2.61s	_{p=0.232 n=6}
_{Total Time}	_{13.98s (± 0.21%)}	_{14.01s (± 0.33%)}	_~	_13.97s	_14.10s	_{p=0.146 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,313k (± 0.00%)}	_{347,339k (± 0.01%)}	_~	_347,299k	_347,402k	_{p=0.066 n=6}
_{Parse Time}	_{2.49s (± 0.33%)}	_{2.48s (± 0.21%)}	_~	_2.48s	_2.49s	_{p=0.523 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.595 n=6}
_{Check Time}	_{6.92s (± 0.25%)}	_{6.95s (± 0.40%)}	_~	_6.90s	_6.98s	_{p=0.193 n=6}
_{Emit Time}	_{4.06s (± 0.46%)}	_{4.06s (± 0.43%)}	_~	_4.04s	_4.09s	_{p=0.461 n=6}
_{Total Time}	_{14.40s (± 0.20%)}	_{14.41s (± 0.25%)}	_~	_14.37s	_14.47s	_{p=0.747 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,769k (± 0.00%)}	_{302,778k (± 0.01%)}	_~	_302,749k	_302,833k	_{p=0.809 n=6}
_{Parse Time}	_{2.01s (± 0.92%)}	_{2.02s (± 0.51%)}	_~	_2.00s	_2.03s	_{p=1.000 n=6}
_{Bind Time}	_{1.00s (± 1.37%)}	_{1.01s (± 1.45%)}	_~	_0.99s	_1.03s	_{p=0.458 n=6}
_{Check Time}	_{6.32s (± 0.24%)}	_{6.33s (± 0.36%)}	_~	_6.31s	_6.36s	_{p=0.563 n=6}
_{Emit Time}	_{3.60s (± 0.76%)}	_{3.60s (± 0.72%)}	_~	_3.56s	_3.64s	_{p=0.936 n=6}
_{Total Time}	_{12.93s (± 0.27%)}	_{12.96s (± 0.28%)}	_~	_12.93s	_13.03s	_{p=0.293 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,247k (± 0.00%)}	_{511,249k (± 0.00%)}	_~	_511,232k	_511,282k	_{p=0.936 n=6}
_{Parse Time}	_{2.65s (± 0.55%)}	_{2.66s (± 0.34%)}	_~	_2.65s	_2.67s	_{p=0.363 n=6}
_{Bind Time}	_{0.98s (± 1.05%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.351 n=6}
_{Check Time}	_{17.30s (± 0.48%)}	_{17.31s (± 0.47%)}	_~	_17.17s	_17.39s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.93s (± 0.33%)}	_{20.96s (± 0.40%)}	_~	_20.81s	_21.04s	_{p=0.520 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,789,396k (± 0.00%)}	_{1,789,436k (± 0.00%)}	_{+40k (+ 0.00%)}	_1,789,393k	_1,789,493k	_{p=0.031 n=6}
_{Parse Time}	_{6.63s (± 0.33%)}	_{6.63s (± 0.66%)}	_~	_6.58s	_6.70s	_{p=0.871 n=6}
_{Bind Time}	_{2.39s (± 0.34%)}	_{2.40s (± 0.23%)}	_~	_2.39s	_2.40s	_{p=0.054 n=6}
_{Check Time}	_{59.01s (± 0.46%)}	_{58.98s (± 0.52%)}	_~	_58.59s	_59.29s	_{p=0.748 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.17s (± 2.42%)}	_~	_0.16s	_0.17s	_{p=0.112 n=6}
_{Total Time}	_{68.19s (± 0.41%)}	_{68.17s (± 0.48%)}	_~	_67.75s	_68.54s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,906k (± 0.02%)}	_{2,394,683k (± 0.02%)}	_~	_2,394,004k	_2,395,332k	_{p=0.810 n=6}
_{Parse Time}	_{5.02s (± 0.68%)}	_{5.02s (± 1.18%)}	_~	_4.94s	_5.11s	_{p=0.810 n=6}
_{Bind Time}	_{1.89s (± 0.70%)}	_{1.90s (± 0.88%)}	_~	_1.88s	_1.92s	_{p=0.227 n=6}
_{Check Time}	_{33.60s (± 0.20%)}	_{33.58s (± 0.22%)}	_~	_33.47s	_33.70s	_{p=0.471 n=6}
_{Emit Time}	_{2.69s (± 1.96%)}	_{2.67s (± 1.40%)}	_~	_2.60s	_2.71s	_{p=1.000 n=6}
_{Total Time}	_{43.21s (± 0.19%)}	_{43.18s (± 0.29%)}	_~	_43.02s	_43.31s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,600k (± 0.01%)}	_{414,624k (± 0.01%)}	_~	_414,596k	_414,671k	_{p=0.229 n=6}
_{Parse Time}	_{2.81s (± 0.58%)}	_{2.82s (± 0.83%)}	_~	_2.79s	_2.85s	_{p=0.935 n=6}
_{Bind Time}	_{1.06s (± 0.71%)}	_{1.07s (± 0.38%)}	_~	_1.06s	_1.07s	_{p=0.100 n=6}
_{Check Time}	_{15.20s (± 0.43%)}	_{15.20s (± 0.18%)}	_~	_15.18s	_15.24s	_{p=0.805 n=6}
_{Emit Time}	_{1.13s (± 0.92%)}	_{1.13s (± 0.74%)}	_~	_1.12s	_1.14s	_{p=0.672 n=6}
_{Total Time}	_{20.20s (± 0.29%)}	_{20.21s (± 0.25%)}	_~	_20.17s	_20.29s	_{p=0.467 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,871,177k (± 0.00%)}	_{2,871,171k (± 0.00%)}	_~	_2,870,908k	_2,871,270k	_{p=0.873 n=6}
_{Parse Time}	_{10.78s (± 0.36%)}	_{10.78s (± 0.23%)}	_~	_10.75s	_10.82s	_{p=0.747 n=6}
_{Bind Time}	_{3.46s (± 0.54%)}	_{3.46s (± 0.30%)}	_~	_3.44s	_3.47s	_{p=0.934 n=6}
_{Check Time}	_{61.11s (± 0.43%)}	_{61.16s (± 0.64%)}	_~	_60.77s	_61.76s	_{p=1.000 n=6}
_{Emit Time}	_{16.89s (± 8.12%)}	_{16.89s (± 8.23%)}	_~	_16.16s	_19.72s	_{p=0.936 n=6}
_{Total Time}	_{92.24s (± 1.73%)}	_{92.28s (± 1.84%)}	_~	_91.29s	_95.69s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{404,905k (± 0.01%)}	_{404,865k (± 0.01%)}	_~	_404,809k	_404,928k	_{p=0.261 n=6}
_{Parse Time}	_{3.23s (± 0.26%)}	_{3.25s (± 0.42%)}	_~	_3.23s	_3.27s	_{p=0.109 n=6}
_{Bind Time}	_{1.40s (± 0.95%)}	_{1.41s (± 0.98%)}	_~	_1.38s	_1.42s	_{p=0.323 n=6}
_{Check Time}	_{14.06s (± 0.36%)}	_{14.05s (± 0.28%)}	_~	_14.01s	_14.10s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.70s (± 0.23%)}	_{18.71s (± 0.28%)}	_~	_18.64s	_18.78s	_{p=0.688 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,189k (± 0.01%)}	_{513,176k (± 0.01%)}	_~	_513,126k	_513,220k	_{p=0.810 n=6}
_{Parse Time}	_{3.27s (± 0.25%)}	_{3.29s (± 0.23%)}	_{+0.01s (+ 0.46%)}	_3.28s	_3.30s	_{p=0.015 n=6}
_{Bind Time}	_{1.54s (± 0.41%)}	_{1.54s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.673 n=6}
_{Check Time}	_{2.87s (± 0.64%)}	_{2.85s (± 0.61%)}	_~	_2.84s	_2.88s	_{p=0.222 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{7.77s (± 0.19%)}	_{7.77s (± 0.24%)}	_~	_7.75s	_7.79s	_{p=0.624 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

ahejlsberg · 2024-03-12T21:16:43Z

Tests and performance are all clean. I think this is ready to merge.

…e-5.4 (#57753) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

ahejlsberg added 2 commits March 12, 2024 12:04

Exclude generic string-like types from intersection reduction

8902922

Add regression test

d59297e

typescript-bot assigned ahejlsberg Mar 12, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 12, 2024

ahejlsberg requested a review from RyanCavanaugh March 12, 2024 19:09

typescript-bot mentioned this pull request Mar 12, 2024

🤖 Pick PR #57751 (Exclude generic string-like types f...) into release-5.4 #57753

Merged

jakebailey approved these changes Mar 13, 2024

View reviewed changes

RyanCavanaugh approved these changes Mar 13, 2024

View reviewed changes

RyanCavanaugh pushed a commit that referenced this pull request Mar 13, 2024

🤖 Pick PR #57751 (Exclude generic string-like types f...) into releas…

7f11456

…e-5.4 (#57753) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

ahejlsberg merged commit 952dfc5 into main Mar 13, 2024
19 checks passed

ahejlsberg deleted the fix57736 branch March 13, 2024 23:13

DanielRosenwasser added this to the TypeScript 5.4.3 milestone Mar 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude generic string-like types from intersection reduction #57751

Exclude generic string-like types from intersection reduction #57751

ahejlsberg commented Mar 12, 2024

ahejlsberg commented Mar 12, 2024

typescript-bot commented Mar 12, 2024 •

edited

typescript-bot commented Mar 12, 2024

typescript-bot commented Mar 12, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

RyanCavanaugh commented Mar 12, 2024

typescript-bot commented Mar 12, 2024 •

edited

typescript-bot commented Mar 12, 2024

typescript-bot commented Mar 12, 2024

typescript-bot commented Mar 12, 2024

tsc

ahejlsberg commented Mar 12, 2024

Exclude generic string-like types from intersection reduction #57751

Exclude generic string-like types from intersection reduction #57751

Conversation

ahejlsberg commented Mar 12, 2024

ahejlsberg commented Mar 12, 2024

typescript-bot commented Mar 12, 2024 • edited

typescript-bot commented Mar 12, 2024

typescript-bot commented Mar 12, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

RyanCavanaugh commented Mar 12, 2024

typescript-bot commented Mar 12, 2024 • edited

typescript-bot commented Mar 12, 2024

typescript-bot commented Mar 12, 2024

typescript-bot commented Mar 12, 2024

tsc

ahejlsberg commented Mar 12, 2024

typescript-bot commented Mar 12, 2024 •

edited

typescript-bot commented Mar 12, 2024 •

edited