Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Defer processing of nested generic calls that return construc… #57746

Merged
merged 1 commit into from Mar 12, 2024

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Mar 12, 2024

…tor types (#54813)"

This reverts commit 8d1fa44.

Reverts #54813
Patches #57710, but does not fix the underlying bug.

However, @weswigham believes that this change exposed an existing problem, so the long-term fix is to find that problem, fix it, and then re-apply this change.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 12, 2024
@sandersn sandersn requested a review from weswigham March 12, 2024 17:37
@sandersn sandersn enabled auto-merge (squash) March 12, 2024 17:52
@sandersn sandersn disabled auto-merge March 12, 2024 17:53
@sandersn sandersn merged commit e660490 into microsoft:main Mar 12, 2024
19 checks passed
@sandersn sandersn deleted the revert-54813 branch March 12, 2024 17:53
@RyanCavanaugh
Copy link
Member

@typescript-bot cherry-pick this to release-5.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 12, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.4 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @RyanCavanaugh! I've created #57752 for you.

RyanCavanaugh pushed a commit that referenced this pull request Mar 15, 2024
…e-5.4 (#57752)

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.4.3 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants