No `this` type arguments in base constraints #54536

ahejlsberg · 2023-06-05T16:31:28Z

This PR implements the following:

When a base constraint resolves to a type reference, we no longer add a this type argument to the reference. Instead, this type arguments are only added when obtaining apparent types.
When the target side of a type relation check is a conditional type, we ignore instantiations of the same conditional type on the source side (as we may otherwise generate a lot of useless work during variance computation).
When obtaining constraints for tuple types, we only perform substitutions for variadic elements only when the element references a type parameter (as opposed to an arbitrary generic type). This reduces instances of deeply recursive constraints.

With these changes, the repros in #54491 now type check faster than in 5.0.

ahejlsberg · 2023-06-05T16:33:21Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-06-05T16:33:25Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 9d570a0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T16:33:25Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 9d570a0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T16:33:25Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 9d570a0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T16:33:25Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 9d570a0. You can monitor the build here.

typescript-bot · 2023-06-05T16:33:25Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 9d570a0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T16:49:31Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54536

_Metric	_main	₅₄₅₃₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,512k (± 0.01%)}	_{365,489k (± 0.01%)}	_~	_365,464k	_365,548k	_{p=0.296 n=6}
_{Parse Time}	_{3.55s (± 0.48%)}	_{3.57s (± 0.65%)}	_~	_3.54s	_3.60s	_{p=0.123 n=6}
_{Bind Time}	_{1.18s (± 0.35%)}	_{1.18s (± 0.35%)}	_~	_1.18s	_1.19s	_{p=0.218 n=6}
_{Check Time}	_{9.57s (± 0.65%)}	_{9.65s (± 0.39%)}	_{+0.08s (+ 0.82%)}	_9.61s	_9.70s	_{p=0.037 n=6}
_{Emit Time}	_{7.88s (± 0.67%)}	_{7.97s (± 1.11%)}	_~	_7.86s	_8.08s	_{p=0.109 n=6}
_{Total Time}	_{22.18s (± 0.42%)}	_{22.37s (± 0.56%)}	_~	_22.25s	_22.53s	_{p=0.054 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,025k (± 0.89%)}	_{192,584k (± 0.02%)}	_{-1,441k (- 0.74%)}	_192,522k	_192,649k	_{p=0.005 n=6}
_{Parse Time}	_{1.60s (± 0.32%)}	_{1.61s (± 0.75%)}	_~	_1.59s	_1.62s	_{p=0.666 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.201 n=6}
_{Check Time}	_{10.15s (± 0.79%)}	_{10.19s (± 0.57%)}	_~	_10.14s	_10.30s	_{p=0.229 n=6}
_{Emit Time}	_{3.01s (± 0.34%)}	_{3.00s (± 0.60%)}	_~	_2.97s	_3.02s	_{p=0.211 n=6}
_{Total Time}	_{15.59s (± 0.50%)}	_{15.62s (± 0.34%)}	_~	_15.58s	_15.71s	_{p=0.422 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,888k (± 0.00%)}	_{345,869k (± 0.00%)}	_~	_345,853k	_345,893k	_{p=0.065 n=6}
_{Parse Time}	_{2.73s (± 0.38%)}	_{2.74s (± 0.44%)}	_~	_2.72s	_2.75s	_{p=0.675 n=6}
_{Bind Time}	_{1.09s (± 0.82%)}	_{1.08s (± 0.75%)}	_~	_1.07s	_1.09s	_{p=0.270 n=6}
_{Check Time}	_{7.85s (± 0.78%)}	_{7.90s (± 0.44%)}	_~	_7.86s	_7.95s	_{p=0.109 n=6}
_{Emit Time}	_{4.47s (± 0.90%)}	_{4.48s (± 0.89%)}	_~	_4.43s	_4.53s	_{p=1.000 n=6}
_{Total Time}	_{16.14s (± 0.51%)}	_{16.20s (± 0.33%)}	_~	_16.11s	_16.27s	_{p=0.297 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,962k (± 0.00%)}	_{299,962k (± 0.01%)}	_~	_299,938k	_300,008k	_{p=0.423 n=6}
_{Parse Time}	_{2.16s (± 0.96%)}	_{2.16s (± 0.70%)}	_~	_2.15s	_2.19s	_{p=0.933 n=6}
_{Bind Time}	_{1.23s (± 0.66%)}	_{1.24s (± 1.18%)}	_~	_1.23s	_1.26s	_{p=0.498 n=6}
_{Check Time}	_{7.27s (± 0.68%)}	_{7.31s (± 0.29%)}	_~	_7.28s	_7.34s	_{p=0.077 n=6}
_{Emit Time}	_{4.34s (± 0.60%)}	_{4.37s (± 0.63%)}	_~	_4.33s	_4.41s	_{p=0.106 n=6}
_{Total Time}	_{15.00s (± 0.41%)}	_{15.08s (± 0.32%)}	_~	_15.03s	_15.17s	_{p=0.054 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{480,995k (± 0.01%)}	_{480,338k (± 0.01%)}	_{-658k (- 0.14%)}	_480,297k	_480,366k	_{p=0.005 n=6}
_{Parse Time}	_{3.26s (± 0.17%)}	_{3.26s (± 0.37%)}	_~	_3.24s	_3.27s	_{p=0.865 n=6}
_{Bind Time}	_{0.94s (± 0.67%)}	_{0.94s (± 0.95%)}	_~	_0.93s	_0.95s	_{p=1.000 n=6}
_{Check Time}	_{17.89s (± 0.63%)}	_{17.95s (± 0.91%)}	_~	_17.78s	_18.19s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.08s (± 0.50%)}	_{22.14s (± 0.75%)}	_~	_21.98s	_22.38s	_{p=0.810 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,684k (± 0.02%)}	_{560,586k (± 0.01%)}	_~	_560,480k	_560,675k	_{p=0.173 n=6}
_{Parse Time}	_{3.99s (± 0.29%)}	_{4.00s (± 0.19%)}	_~	_3.99s	_4.01s	_{p=0.157 n=6}
_{Bind Time}	_{1.76s (± 0.51%)}	_{1.77s (± 0.80%)}	_~	_1.75s	_1.79s	_{p=0.215 n=6}
_{Check Time}	_{3.06s (± 0.82%)}	_{3.06s (± 0.48%)}	_~	_3.04s	_3.08s	_{p=0.515 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.90s (± 0.35%)}	_{8.92s (± 0.21%)}	_~	_8.90s	_8.94s	_{p=0.334 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₅₃₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-06-05T17:00:45Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/54536/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-06-05T18:32:58Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/54536/merge:

Everything looks good!

typescript-bot · 2023-06-05T18:42:17Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Andarist · 2023-06-05T19:41:52Z

This PR also fixes #54495 , cc @alecgibson

DanielRosenwasser · 2023-06-05T21:28:53Z

@typescript-bot pack this

typescript-bot · 2023-06-05T21:28:56Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 9d570a0. You can monitor the build here.

typescript-bot · 2023-06-05T21:30:33Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155350/artifacts?artifactName=tgz&fileId=25390837027CDB2F59440AFD227BEAC42D7474DF7E5DDBB45B82274982C27B3002&fileName=/typescript-5.2.0-insiders.20230605.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-54536-13".;

DanielRosenwasser · 2023-06-05T21:47:17Z

@typescript-bot user test tsserver
@typescript-bot test tsserver top100

typescript-bot · 2023-06-05T21:47:22Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 9d570a0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T21:47:22Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 9d570a0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T22:02:28Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/54536/merge:

Everything looks good!

typescript-bot · 2023-06-06T00:04:03Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/54536/merge:

Everything looks good!

jakebailey · 2023-06-08T03:33:49Z

Apparently this is blocking ts-eslint from upgrading to 5.1; this is intended to be cherry-picked, right? @DanielRosenwasser

jakebailey · 2023-06-09T07:16:06Z

Scratch that, it's actually #54542 (comment)

DanielRosenwasser · 2023-06-08T17:33:54Z

tests/baselines/reference/complexRecursiveCollections.errors.txt

-!!! error TS2430:       'this' could be instantiated with an arbitrary type which could be unrelated to 'Set<T>'.
+!!! error TS2430:       'Set<T>' is assignable to the constraint of type 'this', but 'this' could be instantiated with a different subtype of constraint 'Set<T>'.


Well this is definitely an improvement. 😄

# Conflicts: # tests/baselines/reference/complexRecursiveCollections.errors.txt

DanielRosenwasser · 2023-06-13T16:27:48Z

@typescript-bot cherry-pick this to release-5.1

typescript-bot · 2023-06-13T16:27:51Z

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.1 on this PR at f0b25b3. You can monitor the build here.

typescript-bot · 2023-06-13T16:33:51Z

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.1 manually.

…o release-5.1 (#54814) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

ahejlsberg added 3 commits June 5, 2023 09:12

No this type argument in base constraints + stricter tuple constraints

8587878

Accept new baselines

8581c12

Add regression test

9d570a0

typescript-bot assigned ahejlsberg Jun 5, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 5, 2023

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh June 5, 2023 20:02

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 5, 2023

JoshuaKGoldberg mentioned this pull request Jun 8, 2023

feat: support TypeScript 5.1 typescript-eslint/typescript-eslint#7088

Merged

3 tasks

extremeheat mentioned this pull request Jun 9, 2023

Bump typescript from 5.0.4 to 5.1.3 PrismarineJS/node-minecraft-data#288

Closed

DanielRosenwasser approved these changes Jun 12, 2023

View reviewed changes

Merge branch 'main' into fix54491

f0b25b3

# Conflicts: # tests/baselines/reference/complexRecursiveCollections.errors.txt

ahejlsberg merged commit 89cbea8 into main Jun 13, 2023
15 of 16 checks passed

ahejlsberg deleted the fix54491 branch June 13, 2023 02:07

alecgibson mentioned this pull request Jun 13, 2023

PSA: TS 5.1 can break using this library gcanti/io-ts#698

Closed

Andarist mentioned this pull request Jun 28, 2023

5.1 regression: constraints of generic tuple types are sometimes order-sensitive #54495

Closed

jakebailey pushed a commit to jakebailey/TypeScript that referenced this pull request Jun 28, 2023

No this type arguments in base constraints (microsoft#54536)

30fcc5b

jakebailey mentioned this pull request Jun 28, 2023

cherry pick "No this type arguments in base constraints (#54536)" to release-5.1 #54814

Merged

DanielRosenwasser pushed a commit that referenced this pull request Jun 28, 2023

cherry pick "No this type arguments in base constraints (#54536)" t…

ac5884a

…o release-5.1 (#54814) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No `this` type arguments in base constraints #54536

No `this` type arguments in base constraints #54536

ahejlsberg commented Jun 5, 2023 •

edited

ahejlsberg commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

Andarist commented Jun 5, 2023

DanielRosenwasser commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

DanielRosenwasser commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 6, 2023

jakebailey commented Jun 8, 2023

jakebailey commented Jun 9, 2023

DanielRosenwasser Jun 8, 2023

DanielRosenwasser commented Jun 13, 2023

typescript-bot commented Jun 13, 2023 •

edited

typescript-bot commented Jun 13, 2023

		!!! error TS2430: 'this' could be instantiated with an arbitrary type which could be unrelated to 'Set<T>'.
		!!! error TS2430: 'Set<T>' is assignable to the constraint of type 'this', but 'this' could be instantiated with a different subtype of constraint 'Set<T>'.

No this type arguments in base constraints #54536

No this type arguments in base constraints #54536

Conversation

ahejlsberg commented Jun 5, 2023 • edited

ahejlsberg commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

Andarist commented Jun 5, 2023

DanielRosenwasser commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023 • edited

DanielRosenwasser commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023 • edited

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 6, 2023

jakebailey commented Jun 8, 2023

jakebailey commented Jun 9, 2023

DanielRosenwasser Jun 8, 2023

Choose a reason for hiding this comment

DanielRosenwasser commented Jun 13, 2023

typescript-bot commented Jun 13, 2023 • edited

typescript-bot commented Jun 13, 2023

No `this` type arguments in base constraints #54536

No `this` type arguments in base constraints #54536

ahejlsberg commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 5, 2023 •

edited

typescript-bot commented Jun 13, 2023 •

edited